Closed
Bug 66598
Opened 25 years ago
Closed 21 years ago
Use NS_LITERAL_STRING in absync/src/nsAbSync.cpp
Categories
(SeaMonkey :: MailNews: Address Book & Contacts, defect)
SeaMonkey
MailNews: Address Book & Contacts
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: chuang, Assigned: cavin)
References
Details
We should change these lines to NS_LITERAL_STRING. This will remove 2
allocations per line!
nsString(NS_ConvertASCIItoUCS2("1")).ToNewUnicode();
nsString(NS_ConvertASCIItoUCS2("0")).ToNewUnicode();
to
aName = NS_LITERAL_STRING("1");
and make aName a const PRUnichar *;
OS: Windows NT → All
QA Contact: esther → stephend
Hardware: PC → All
Might this help perf, even slightly?
|
||
Comment 2•23 years ago
|
||
taking all of chuang's bugs. she doesn't work on mozilla anymore.
Assignee: chuang → sspitzer
|
|
Assignee | |
Comment 3•23 years ago
|
||
This is fixed as part of the patch for bug 183087. Adding dependency.
Assignee: sspitzer → cavin
Depends on: 183087
|
|
||
Comment 4•21 years ago
|
||
nsAbSync was removed from mozilla, se bug 185716.
I guess this bug is no longer valid
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → WORKSFORME
|
||
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•