detectflash.js recent code update breaks localization

RESOLVED FIXED

Status

www.mozilla.org
General
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: pascalc, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Created attachment 540840 [details]
Screenshot of the bug

The detectflash.js library used on whatsnew pages was recently updated with code from mozilla.jp in r90331 and that update broke the dynamic localization of the strings, the flash warning message is now displayed in English instead of being in the page language. See screenshot.
(Reporter)

Comment 1

7 years ago
This is because the global variables FlashAlertTitle and  FlashAlertText which are of global scope and set outside of the library or now reset to local variable in the library. r91116 fixes that
(Reporter)

Comment 2

7 years ago
fixed on trunk
https://www-trunk.stage.mozilla.com/it/firefox/3.6.18/whatsnew
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Component: www.mozilla.org/firefox → www.mozilla.org
Product: Websites → Websites
(Assignee)

Updated

6 years ago
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.