66601 - drag-and-drop from local listing to another window should open file

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect, P3)

Description

[Jesse Ruderman]

1. Open ftp://ftp.mozilla.org/ in one Mozilla window.
2. Open another browser window (Mozilla, IE, Netscape 4, etc).
3. Drag the README to the other window.

Result:
- Dragging to IE or Opera: get a "no-drag" cursor.
- Dragging to Netscape 4: NS 4 tries to grab a file named /README README and 
fails.
- Dragging to Mozilla: get a normal "drag-and-drop" cursor, but nothing happens 
on drop.

This bug disagrees with bug 66599, "ftp tree appears to be able to accept drag-
and-drop", to some extent.

(Would this be mutually exclusive with the ability to drag-and-drop files from 
ftp into Explorer folders as a way of downloading the files?)

Comment 1

[Jesse Ruderman]

-> drag-and-drop component

Comment 2

[Blake Ross]

Works now that ftp doesn't use the xul viewer anymore.  Reopen if it ever does
again.

Comment 3

[Jesse Ruderman]

Still broken with local directory listings (which still use the tree view).

Comment 4

[Blake Ross]

-->bbaetz

Comment 5

[Bradley Baetz (:bbaetz)]

The drag and drop foo in directory.js is wrong. Specifically, we set a
text/unicode flavour to the id + " " + name, and a moz/rdfitem flavour to the id
+ "\n" + the parent id.

-> 0.9.7 for dirviewer rewrite

Comment 6

[Bradley Baetz (:bbaetz)]

OK, I have a patch, basically involving rewriting data setting parts of the drag
function from scratch.

This doesn't fix dragging to the personal toolbar, because the code which does
that sees that the link is part of a <tree>, and tries to convert the uri to an
rdf bookmarks resource, which obviously fails.

Ben says that this will be fixed when I move to <outliner>, but I suspect that
it will actully be fixed when bookmarks-liner lands (if blake patched that
code), and then broken again when I move to outliner. That dnd code also does
ugly things like assume that the first element in the list is a uri string (its
not), and other fun stuff.

Anyway, dragging to a new window works, as does dragging to the home button

Comment 7

[Bradley Baetz (:bbaetz)]

Attachment: patch

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 56453 [details] [diff] [review]
patch

sr=[e-mail]

Comment 9

[Blake Ross]

Comment on attachment 56453 [details] [diff] [review]
patch

r=blake

Comment 10

[Blake Ross]

Comment on attachment 56453 [details] [diff] [review]
patch

r=blake

Comment 11

[Blake Ross]

Comment on attachment 56453 [details] [diff] [review]
patch

r=blake

Comment 12

[Bradley Baetz (:bbaetz)]

Checked in