Last Comment Bug 666049 - Remove JSFloat64, float64 and float32
: Remove JSFloat64, float64 and float32
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla10
Assigned To: Paul Biggar
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: 666042
  Show dependency treegraph
Reported: 2011-06-21 15:10 PDT by Paul Biggar
Modified: 2011-11-01 08:00 PDT (History)
6 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

remove extra float types (5.87 KB, patch)
2011-06-21 15:10 PDT, Paul Biggar
luke: review+
Details | Diff | Splinter Review
refreshed (4.56 KB, patch)
2011-10-31 10:58 PDT, Tom Schuster [:evilpie]
no flags Details | Diff | Splinter Review

Description User image Paul Biggar 2011-06-21 15:10:31 PDT
Created attachment 540908 [details] [diff] [review]
remove extra float types

float32 is unused, the others should just be doubles, and are in practice.

This has a use in jsd, which can be trivially removed. Does that need a separate patch and review?
Comment 1 User image Tom Schuster [:evilpie] 2011-10-31 10:58:31 PDT
Created attachment 570763 [details] [diff] [review]
Comment 3 User image Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-11-01 07:35:21 PDT

Seeing pbiggar in the commit log made me do a double take ;-)
Comment 4 User image Paul Biggar 2011-11-01 08:00:32 PDT
(In reply to Kyle Huey [:khuey] ( from comment #3) 
> Seeing pbiggar in the commit log made me do a double take ;-)

Yeah, me too!

Note You need to log in before you can comment on or make changes to this bug.