Closed Bug 6662 Opened 21 years ago Closed 21 years ago

PR_Open does not set hpb.fileParam.ioDirID before calling PBHOpenSync or PBHCreateSync

Categories

(NSPR :: NSPR, defect, P3)

3.1.1
PowerPC
Mac System 8.5
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wtc, Assigned: gordon)

Details

This bug is reported by ducarroz@netscape.com (Jean-Francois Ducarroz):

****************** begin message ************************

I just found that PR_Open works randomly on Mac.

PR_Open uses  PBHOpenSync(&hpb) and eventually PBHCreateSync(&hpb)
if the file need to be created. It doesn't work because the
hpb.fileParam.ioDirID is never set (to 0) before calling
PBHOpenSync or PBHCreateSync and therefore contains a random value.

here is the fix:

Index: macio.c
===================================================================

RCS file: /cvsroot/mozilla/nsprpub/pr/src/md/mac/macio.c,v
retrieving revision 3.11
diff -r3.11 macio.c
360a361
>  hpb.fileParam.ioDirID   = 0;

*************** end message **************************************

Steve, Gordon, does this fix look okay?
Assignee: sdagley → gordon
Target Milestone: M6
Status: NEW → ASSIGNED
We should also be using PBHOpenDFSync() instead.  I'll take this one.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: M6 → ---
You need to log in before you can comment on or make changes to this bug.