Closed Bug 666231 Opened 13 years ago Closed 13 years ago

Monochrome graphics for the message list tree header

Categories

(Thunderbird :: Theme, defect)

All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 10.0

People

(Reporter: andreasn, Assigned: andreasn)

References

Details

Attachments

(3 files, 2 obsolete files)

Attached image mockup
Similar to bug 666229 and bug 665871, we could use this single colored style in the tree headers as well.
Blocks: 665873
Attached patch implements monochrome headers (obsolete) — Splinter Review
Port from bug #588007
Implements single colored graphics that adapts to the text color in message list and search window.
Attachment #547040 - Flags: ui-review?(bwinton)
Attachment #547040 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 547040 [details] [diff] [review]
implements monochrome headers

Review of attachment 547040 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me, aside from a couple of padding issues. r=me with those fixed.

As something to consider though: should the star/junk icons be solid or outlines? Outlines seem to fit in more with the rest of the columns (since they're text or thin-lined icons), and they'd jump out a bit less. However, that's not a big deal, and I'm not even really sure we want that.

::: mail/themes/gnomestripe/mail/mailWindow1.css
@@ +131,1 @@
>    -moz-padding-end: 3px; 

I think this looks better-centered without the padding on the end.

@@ +154,2 @@
>    -moz-padding-end: 5px;
>    padding-bottom: 5px;

Likewise, I think the padding on the end should be 3px here. Also, it's not caused by this bug, but could you remove the padding-bottom as well? Adding the "read" column increases the height of the tree header by a couple of pixels, which is annoying.

@@ +175,1 @@
>    -moz-padding-end: 5px; 

3px padding here.

@@ +187,1 @@
>    -moz-padding-end: 5px; 

And here.

@@ +207,1 @@
>    -moz-padding-end: 5px; 

And here.
Attachment #547040 - Flags: review?(squibblyflabbetydoo) → review+
Fixes review requests and carries over r+.
Attachment #547040 - Attachment is obsolete: true
Attachment #548581 - Flags: ui-review?(bwinton)
Attachment #548581 - Flags: review+
Attachment #547040 - Flags: ui-review?(bwinton)
Oops, I totally missed the searchDialog.css file! I think we should make the same padding changes there as well.
Attachment #548581 - Attachment is obsolete: true
Attachment #548581 - Flags: ui-review?(bwinton)
Comment on attachment 548604 [details] [diff] [review]
and fixes the search dialog as well

Looks good to me, based purely on inspection.
Attachment #548604 - Flags: review+
Attachment #548604 - Flags: ui-review?(bwinton)
Assignee: nobody → nisses.mail
Comment on attachment 548604 [details] [diff] [review]
and fixes the search dialog as well

The junk button needs to be moved up a pixel.
The star and paperclip need to be moved left a pixel (or preferably the icons underneath them need to be moved right a pixel)
The eyeglasses need to be moved right a pixel (or maybe made a pixel bigger to the right).

ui-r=me with those fixed.  ;)

Thanks,
Blake.
Attachment #548604 - Flags: ui-review?(bwinton) → ui-review+
> The junk button needs to be moved up a pixel.
Fixed

> The star and paperclip need to be moved left a pixel (or preferably the icons underneath them need to be moved right a pixel)
The icons below are now aligned right below the header icons.

> The eyeglasses need to be moved right a pixel (or maybe made a pixel bigger to the right).
Fixed.
Comment on attachment 561721 [details] [diff] [review]
fixing alignments issues from ui review

Carrying over review and ui-review
Attachment #561721 - Flags: ui-review+
Attachment #561721 - Flags: review+
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/e655f329a430
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
You need to log in before you can comment on or make changes to this bug.