Closed
Bug 666231
Opened 13 years ago
Closed 13 years ago
Monochrome graphics for the message list tree header
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 10.0
People
(Reporter: andreasn, Assigned: andreasn)
References
Details
Attachments
(3 files, 2 obsolete files)
10.86 KB,
image/png
|
Details | |
12.70 KB,
patch
|
squib
:
review+
bwinton
:
ui-review+
|
Details | Diff | Splinter Review |
18.51 KB,
patch
|
andreasn
:
review+
andreasn
:
ui-review+
|
Details | Diff | Splinter Review |
Similar to bug 666229 and bug 665871, we could use this single colored style in the tree headers as well.
Assignee | ||
Comment 1•13 years ago
|
||
Port from bug #588007 Implements single colored graphics that adapts to the text color in message list and search window.
Assignee | ||
Updated•13 years ago
|
Attachment #547040 -
Flags: ui-review?(bwinton)
Attachment #547040 -
Flags: review?(squibblyflabbetydoo)
Comment 2•13 years ago
|
||
Comment on attachment 547040 [details] [diff] [review] implements monochrome headers Review of attachment 547040 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me, aside from a couple of padding issues. r=me with those fixed. As something to consider though: should the star/junk icons be solid or outlines? Outlines seem to fit in more with the rest of the columns (since they're text or thin-lined icons), and they'd jump out a bit less. However, that's not a big deal, and I'm not even really sure we want that. ::: mail/themes/gnomestripe/mail/mailWindow1.css @@ +131,1 @@ > -moz-padding-end: 3px; I think this looks better-centered without the padding on the end. @@ +154,2 @@ > -moz-padding-end: 5px; > padding-bottom: 5px; Likewise, I think the padding on the end should be 3px here. Also, it's not caused by this bug, but could you remove the padding-bottom as well? Adding the "read" column increases the height of the tree header by a couple of pixels, which is annoying. @@ +175,1 @@ > -moz-padding-end: 5px; 3px padding here. @@ +187,1 @@ > -moz-padding-end: 5px; And here. @@ +207,1 @@ > -moz-padding-end: 5px; And here.
Attachment #547040 -
Flags: review?(squibblyflabbetydoo) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Fixes review requests and carries over r+.
Attachment #547040 -
Attachment is obsolete: true
Attachment #548581 -
Flags: ui-review?(bwinton)
Attachment #548581 -
Flags: review+
Attachment #547040 -
Flags: ui-review?(bwinton)
Comment 4•13 years ago
|
||
Oops, I totally missed the searchDialog.css file! I think we should make the same padding changes there as well.
Assignee | ||
Comment 5•13 years ago
|
||
Attachment #548581 -
Attachment is obsolete: true
Attachment #548581 -
Flags: ui-review?(bwinton)
Comment 6•13 years ago
|
||
Comment on attachment 548604 [details] [diff] [review] and fixes the search dialog as well Looks good to me, based purely on inspection.
Attachment #548604 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Attachment #548604 -
Flags: ui-review?(bwinton)
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → nisses.mail
Comment 7•13 years ago
|
||
Comment on attachment 548604 [details] [diff] [review] and fixes the search dialog as well The junk button needs to be moved up a pixel. The star and paperclip need to be moved left a pixel (or preferably the icons underneath them need to be moved right a pixel) The eyeglasses need to be moved right a pixel (or maybe made a pixel bigger to the right). ui-r=me with those fixed. ;) Thanks, Blake.
Attachment #548604 -
Flags: ui-review?(bwinton) → ui-review+
Assignee | ||
Comment 8•13 years ago
|
||
> The junk button needs to be moved up a pixel. Fixed > The star and paperclip need to be moved left a pixel (or preferably the icons underneath them need to be moved right a pixel) The icons below are now aligned right below the header icons. > The eyeglasses need to be moved right a pixel (or maybe made a pixel bigger to the right). Fixed.
Assignee | ||
Comment 9•13 years ago
|
||
Comment on attachment 561721 [details] [diff] [review] fixing alignments issues from ui review Carrying over review and ui-review
Attachment #561721 -
Flags: ui-review+
Attachment #561721 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 10•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/e655f329a430
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
You need to log in
before you can comment on or make changes to this bug.
Description
•