Intermittent browser_tabview_privatebrowsing.js | Test timed out

RESOLVED FIXED in Firefox 8

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: philor, Assigned: ttaubert)

Tracking

({intermittent-failure})

Trunk
Firefox 8
x86_64
Linux
intermittent-failure
Dependency tree / graph

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 years ago
There have been a few of these lately, but we've been calling them other random things.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308733545.1308735250.26021.gz
Rev3 Fedora 12x64 mozilla-central opt test mochitest-other on 2011/06/22 02:05:45
s: talos-r3-fed64-022

TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | we have 1 tab in private browsing
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | we have 1 group in private browsing
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | the tab is in the group
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | correct URL for private browsing
TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | Console message:
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | Test timed out
(Assignee)

Updated

6 years ago
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 years ago
Created attachment 541330 [details] [diff] [review]
patch v1
Attachment #541330 - Flags: feedback?(raymond)
(Assignee)

Comment 2

6 years ago
Created attachment 541331 [details] [diff] [review]
patch v1 (without white space changes)
Attachment #541330 - Flags: feedback?(raymond) → feedback+
(Assignee)

Comment 3

6 years ago
Comment on attachment 541330 [details] [diff] [review]
patch v1

The fix is that we're now adding a tab without zooming right into it. We stay in tabview and therefore don't need to call showTabView(). The test timed out because we didn't wait for the tabview to be hidden before showing it again.
Attachment #541330 - Flags: review?(ehsan)
Attachment #541330 - Flags: review?(ehsan) → review+
Comment hidden (Treeherder Robot)
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/8e1bf0b98a30
Whiteboard: [orange] → [orange], [inbound]
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
backed out from mozilla-inbound because part of a push that increased number of random failures in Panorama browser-chrome tests.
Please reland in smaller chunks when ready.

Updated

6 years ago
Whiteboard: [orange], [inbound] → [orange]
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Updated

6 years ago
Depends on: 662812
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 23

6 years ago
Created attachment 544807 [details] [diff] [review]
patch v2
Attachment #541330 - Attachment is obsolete: true
Attachment #541331 - Attachment is obsolete: true
Attachment #544807 - Flags: review?(ehsan)
Comment on attachment 544807 [details] [diff] [review]
patch v2

>   // register a clean up for private browsing just in case
>   registerCleanupFunction(function() {
>-    pb.privateBrowsingEnabled = false;
>+    if (pb.privateBrowsingEnabled)
>+      pb.privateBrowsingEnabled = false;
>   });

You can just assign to false.  If we're out of PB mode, that would be a no-op.

r=me with that fixed.
Attachment #544807 - Flags: review?(ehsan) → review+
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 27

6 years ago
http://hg.mozilla.org/integration/fx-team/rev/6f1affa4bb5e
Whiteboard: [orange] → [orange][fixed-in-fx-team]
(Assignee)

Comment 28

6 years ago
http://hg.mozilla.org/mozilla-central/rev/6f1affa4bb5e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Target Milestone: --- → Firefox 8

Updated

6 years ago
Blocks: 658738
Prior to this patch, this test used to leak hundreds of windows, see bug 658738 comment 71. Does this make any sense?
Well, not hundreds, but about 139. Anyway, I would really like to know if the test was severely broken or if it revealed an issue that's still there but not exposed anymore.

Updated

6 years ago
No longer blocks: 658738
Ignore my previous comments; bug 651643 killed the leaks, not this bug.
Keywords: intermittent-failure
Whiteboard: [orange]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.