666478 - build/autoconf/make-makefile

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Joey Armstrong [:joey]]

1) Create a unit test for acoutput-fast.pl 
2) Code footprint can be reduced with use of standard perl modules
3) correct a few minor problems.

Code footprint reduction with std modules:
  o unit test should be written before any changes are made to detect regressions.
  o insert "use strict;"
    - localize variables with my
  o insert "use warnings;"
  o replace dirname() subroutine with File::Basename::dirname
  o replace `pwd` with "use Cwd;", module should work properly for cygwin.
  o replace create_director{y,ies} with File::Path::mkpath
    - check exit status after mkdir calls to detect errors
    - replace system("mkdir -p") to avoid shell overhead
    - set "umask 0;" early in the script 
  o replace @ARGV handling with Getopt::Long
  o constructing paths using arrays rather than inplace regexpr edits might simplify the logic somewhat.
  o command should accumulate error state { failed mkdir & open calls) and exit with status

Comment 1

[Joey Armstrong [:joey]]

make-makefile perl script deprecated