build/autoconf/make-makefile

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
7 years ago
6 months ago

People

(Reporter: joey, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
1) Create a unit test for acoutput-fast.pl 
2) Code footprint can be reduced with use of standard perl modules
3) correct a few minor problems.

Code footprint reduction with std modules:
  o unit test should be written before any changes are made to detect regressions.
  o insert "use strict;"
    - localize variables with my
  o insert "use warnings;"
  o replace dirname() subroutine with File::Basename::dirname
  o replace `pwd` with "use Cwd;", module should work properly for cygwin.
  o replace create_director{y,ies} with File::Path::mkpath
    - check exit status after mkdir calls to detect errors
    - replace system("mkdir -p") to avoid shell overhead
    - set "umask 0;" early in the script 
  o replace @ARGV handling with Getopt::Long
  o constructing paths using arrays rather than inplace regexpr edits might simplify the logic somewhat.
  o command should accumulate error state { failed mkdir & open calls) and exit with status
(Reporter)

Comment 1

6 years ago
make-makefile perl script deprecated
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.