666480 - LIR.cpp:286:15: warning: variable ‘priorIns’ set but not used

Status: RESOLVED FIXED

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

Description

[Daniel Holbert [:dholbert]]

gcc-4.6 reports this build warning:
js/src/nanojit/LIR.cpp: In member function ‘void nanojit::CfgLister::printGmlCfg(FILE*, nanojit::LInsPrinter*, nanojit::InsSet*)’:
js/src/nanojit/LIR.cpp:286:15: warning: variable ‘priorIns’ set but not used [-Wunused-but-set-variable]

In the cset that added this variable (for bug 640318)...
  http://hg.mozilla.org/mozilla-central/rev/ab32afc59a89
...the variable is only mentioned in 2 places:
> LIns* priorIns = 0;         // last instruction encountered
and (lower down)
> priorIns = ins;

These lines probably want to just be deleted, right?

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Rick Reitmaier]

(In reply to comment #0)
> These lines probably want to just be deleted, right?

Yes, appears to be dead code.

Comment 3

[William Maddox]

Comment on attachment 541261 [details] [diff] [review]
fix

This is clearly dead code.  R+

Comment 4

[Daniel Holbert [:dholbert]]

Thanks -- what's the protocol for Tamarin checkins?

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: hg changeset for checkin [r=wmaddox]

Here's the patch with r+ noted, ready to hg [q]import & push.

Comment 6

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/projects/nanojit-central/rev/4cc8b8ebd44b

Comment 7

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/tracemonkey/rev/198e53c140cd

Comment 8

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/198e53c140cd

Comment 9

[Tamarin Bot]

changeset: 6476:309d5a15e51b
user:      Daniel Holbert <[e-mail]>
summary:   Bug 666480: Remove set-but-not-used variable 'priorIns' from LIR.cpp. r=wmaddox

http://hg.mozilla.org/tamarin-redux/rev/309d5a15e51b