jsatom.cpp:945:12: warning: variable ‘count’ set but not used

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning][fixed-in-tracemonkey])

Attachments

(1 attachment)

gcc-4.6 reports this build warning:
js/src/jsatom.cpp: In function ‘void js_InitAtomMap(JSContext*, JSAtomMap*, JSAtomList*)’:
js/src/jsatom.cpp:945:12: warning: variable ‘count’ set but not used [-Wunused-but-set-variable]

Bug 385729 removed the last usages of this variable 'count'[1], but left the variable there.  It looks like this variable can just go away.

[1] Lines 1.156 & 1.161 of http://hg.mozilla.org/mozilla-central/diff/5db593415bf1/js/src/jsatom.c#l1.156
Created attachment 541262 [details] [diff] [review]
fix
Attachment #541262 - Flags: review?(igor)

Comment 2

6 years ago
Comment on attachment 541262 [details] [diff] [review]
fix

Review of attachment 541262 [details] [diff] [review]:
-----------------------------------------------------------------

That is a nice feature of GCC 4.6!
Attachment #541262 - Flags: review?(igor) → review+
Assignee: general → dholbert
Status: NEW → ASSIGNED
http://hg.mozilla.org/tracemonkey/rev/4f1eb9b43658
Whiteboard: [build_warning] → [build_warning][fixed-in-tracemonkey]
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/4f1eb9b43658
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.