Add mozapps/skin/plugins/pluginHelp-16.png to Modern (missed out from Bug 601562)

RESOLVED FIXED in seamonkey2.4

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: philip.chee, Assigned: philip.chee)

Tracking

({modern})

Trunk
seamonkey2.4
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.2 fixed, seamonkey2.3 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

8 years ago
Bug 601562 added Modern styling for the plugin crashed/blocked/disabled/required UI bug didn't actually add mozapps/skin/plugins/pluginHelp-16.png to modern despite referencing it.

FYI pluginHelp-16.png is from Bug 550293 (plugin-crashed UI needs more user opt-in).
Assignee

Updated

8 years ago
Summary: Bug 601562 adds Modern styling for the plugin crashed/blocked/disabled/required UI. missed Add mozapps/skin/plugins/pluginHelp-16.png to Modern (missed out from Bug 601562) → Add mozapps/skin/plugins/pluginHelp-16.png to Modern (missed out from Bug 601562)
Assignee

Comment 1

8 years ago
Adds missing pluginHelp-16.png
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #541346 - Flags: review?(neil)
Attachment #541346 - Flags: feedback?(ewong)
Comment on attachment 541346 [details] [diff] [review]
patch v1.0 Add to Modern.

Sorry for missing this on my patch.  Thanks!
Attachment #541346 - Flags: feedback?(ewong) → feedback+
Comment on attachment 541346 [details] [diff] [review]
patch v1.0 Add to Modern.

Would be nice to run this through (pngcrush and) optipng before check in.
Attachment #541346 - Flags: review?(neil) → review+
Assignee

Comment 4

8 years ago
Err, I assumed that the Firefox guys had already done that. Do you really mean *both* PNGcrush and OptiPNG?
Assignee

Comment 5

8 years ago
OK. Compressing with OptiPNG gave a reduction of 620->547 bytes (I turned off all colour and depth reductions). Running pngcrush on the result didn't reduce the file any further.
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/1f69c3277402
Assignee

Comment 6

8 years ago
Comment on attachment 541346 [details] [diff] [review]
patch v1.0 Add to Modern.

asking for comm-aurora and comm-beta since the original patch from Bug 601562 landed on those branches. Low risk, no L10n, just adds a missing file.
Attachment #541346 - Flags: approval-comm-beta?
Attachment #541346 - Flags: approval-comm-aurora?
Attachment #541346 - Flags: approval-comm-beta?
Attachment #541346 - Flags: approval-comm-beta+
Attachment #541346 - Flags: approval-comm-aurora?
Attachment #541346 - Flags: approval-comm-aurora+
Assignee

Comment 7

8 years ago
Pushed:
http://hg.mozilla.org/releases/comm-aurora/rev/81aa6615798a
http://hg.mozilla.org/releases/comm-beta/rev/4ce2cb0ba5c0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
(In reply to comment #4)
> Err, I assumed that the Firefox guys had already done that. Do you really
> mean *both* PNGcrush and OptiPNG?
PNGcrush can remove some of the optional chunks that we don't use, but OptiPNG compresses the image data better. So you generally run PNGcrush first and then OptiPNG on the result.

(In reply to comment #5)
> OK. Compressing with OptiPNG gave a reduction of 620->547 bytes (I turned
> off all colour and depth reductions).
I should have mentioned that (this stops it throwing away the alpha channel). Stefan also recommends a bunch of command-line options for PNGcrush.
Target Milestone: --- → seamonkey2.4
You need to log in before you can comment on or make changes to this bug.