newWindowWithTabView() should wait for browser-delayed-startup-finished

RESOLVED FIXED in Firefox 8

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 8

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
newWindowWithTabView() from head.js should wait for browser-delayed-startup-finished because that is fired after TabView.init() is called.
(Assignee)

Comment 1

6 years ago
Created attachment 541361 [details] [diff] [review]
patch v1
Attachment #541361 - Flags: feedback?(raymond)
Comment on attachment 541361 [details] [diff] [review]
patch v1

Looks good!
Attachment #541361 - Flags: feedback?(raymond) → feedback+
(Assignee)

Updated

6 years ago
Attachment #541361 - Flags: review?(dietrich)
Comment on attachment 541361 [details] [diff] [review]
patch v1

Review of attachment 541361 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #541361 - Flags: review?(dietrich) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/5abf332b2c45
Whiteboard: [inbound]
backed out from mozilla-inbound because part of a push that increased number of random failures in Panorama browser-chrome tests.
Please reland in smaller chunks when ready.
Whiteboard: [inbound]
(Assignee)

Comment 6

6 years ago
Created attachment 542443 [details] [diff] [review]
patch v2

Patch v1 bounced because we need to add the listener for browser-delayed-startup-finished even before the browser's onLoad event is dispatched because that's sometimes too late (so that the delayed startup was already run and we're waiting for that to occur).
Attachment #541361 - Attachment is obsolete: true
Attachment #542443 - Flags: review?(dietrich)
(Assignee)

Comment 7

6 years ago
Created attachment 544427 [details] [diff] [review]
patch v3

Unrotted.
Attachment #542443 - Attachment is obsolete: true
Attachment #544427 - Flags: review?(dietrich)
Attachment #542443 - Flags: review?(dietrich)
(Assignee)

Comment 8

6 years ago
Comment on attachment 544427 [details] [diff] [review]
patch v3

Passed try:

http://tbpl.mozilla.org/?tree=Try&pusher=tim.taubert@gmx.de&rev=65f1bd3eb710
Comment on attachment 544427 [details] [diff] [review]
patch v3

Review of attachment 544427 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #544427 - Flags: review?(dietrich) → review+
(Assignee)

Comment 10

6 years ago
http://hg.mozilla.org/integration/fx-team/rev/4ea2cae8e2dc
Whiteboard: [fixed-in-fx-team]
(Assignee)

Comment 11

6 years ago
http://hg.mozilla.org/mozilla-central/rev/4ea2cae8e2dc
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
(Assignee)

Updated

6 years ago
Target Milestone: --- → Firefox 8
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.