Last Comment Bug 666566 - newWindowWithTabView() should wait for browser-delayed-startup-finished
: newWindowWithTabView() should wait for browser-delayed-startup-finished
Status: RESOLVED FIXED
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: Trunk
: All All
: -- normal
: Firefox 8
Assigned To: Tim Taubert [:ttaubert]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-23 06:29 PDT by Tim Taubert [:ttaubert]
Modified: 2016-04-12 14:00 PDT (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1 (1.32 KB, patch)
2011-06-23 06:37 PDT, Tim Taubert [:ttaubert]
dietrich: review+
raymond: feedback+
Details | Diff | Review
patch v2 (1.31 KB, patch)
2011-06-28 06:29 PDT, Tim Taubert [:ttaubert]
no flags Details | Diff | Review
patch v3 (947 bytes, patch)
2011-07-07 03:02 PDT, Tim Taubert [:ttaubert]
dietrich: review+
Details | Diff | Review

Description Tim Taubert [:ttaubert] 2011-06-23 06:29:56 PDT
newWindowWithTabView() from head.js should wait for browser-delayed-startup-finished because that is fired after TabView.init() is called.
Comment 1 Tim Taubert [:ttaubert] 2011-06-23 06:37:51 PDT
Created attachment 541361 [details] [diff] [review]
patch v1
Comment 2 Raymond Lee [:raymondlee] 2011-06-23 08:54:42 PDT
Comment on attachment 541361 [details] [diff] [review]
patch v1

Looks good!
Comment 3 Dietrich Ayala (:dietrich) 2011-06-23 09:57:59 PDT
Comment on attachment 541361 [details] [diff] [review]
patch v1

Review of attachment 541361 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 5 Marco Bonardo [::mak] 2011-06-24 05:52:39 PDT
backed out from mozilla-inbound because part of a push that increased number of random failures in Panorama browser-chrome tests.
Please reland in smaller chunks when ready.
Comment 6 Tim Taubert [:ttaubert] 2011-06-28 06:29:17 PDT
Created attachment 542443 [details] [diff] [review]
patch v2

Patch v1 bounced because we need to add the listener for browser-delayed-startup-finished even before the browser's onLoad event is dispatched because that's sometimes too late (so that the delayed startup was already run and we're waiting for that to occur).
Comment 7 Tim Taubert [:ttaubert] 2011-07-07 03:02:57 PDT
Created attachment 544427 [details] [diff] [review]
patch v3

Unrotted.
Comment 8 Tim Taubert [:ttaubert] 2011-07-07 15:59:03 PDT
Comment on attachment 544427 [details] [diff] [review]
patch v3

Passed try:

http://tbpl.mozilla.org/?tree=Try&pusher=tim.taubert@gmx.de&rev=65f1bd3eb710
Comment 9 Dietrich Ayala (:dietrich) 2011-07-08 07:56:57 PDT
Comment on attachment 544427 [details] [diff] [review]
patch v3

Review of attachment 544427 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 10 Tim Taubert [:ttaubert] 2011-07-11 10:55:34 PDT
http://hg.mozilla.org/integration/fx-team/rev/4ea2cae8e2dc
Comment 11 Tim Taubert [:ttaubert] 2011-07-13 15:23:16 PDT
http://hg.mozilla.org/mozilla-central/rev/4ea2cae8e2dc

Note You need to log in before you can comment on or make changes to this bug.