666566 - newWindowWithTabView() should wait for browser-delayed-startup-finished

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

newWindowWithTabView() from head.js should wait for browser-delayed-startup-finished because that is fired after TabView.init() is called.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 2

[Raymond Lee [:raymondlee]]

Comment on attachment 541361 [details] [diff] [review]
patch v1

Looks good!

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 541361 [details] [diff] [review]
patch v1

Review of attachment 541361 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5abf332b2c45

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

backed out from mozilla-inbound because part of a push that increased number of random failures in Panorama browser-chrome tests.
Please reland in smaller chunks when ready.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v2

Patch v1 bounced because we need to add the listener for browser-delayed-startup-finished even before the browser's onLoad event is dispatched because that's sometimes too late (so that the delayed startup was already run and we're waiting for that to occur).

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v3

Unrotted.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 544427 [details] [diff] [review]
patch v3

Passed try:

http://tbpl.mozilla.org/?tree=Try&pusher=[e-mail]&rev=65f1bd3eb710

Comment 9

[Dietrich Ayala (:dietrich)]

Comment on attachment 544427 [details] [diff] [review]
patch v3

Review of attachment 544427 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/integration/fx-team/rev/4ea2cae8e2dc

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/mozilla-central/rev/4ea2cae8e2dc