Closed Bug 666580 Opened 8 years ago Closed 8 years ago

Use a transaction for indexedDB schema creation

Categories

(Core :: DOM: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mak, Assigned: mak)

Details

Attachments

(1 file, 1 obsolete file)

This may use a transaction for safety (concurrent connections) and performance (less fsyncs).
Attached patch patch v1.0 (obsolete) — Splinter Review
Apart the transaction that should be pretty stright-forward, is there a reason for immediate being used only for read_write rather than for anything not read_only? I assumed version change is also a write and may like it.
And sorry, As a db lover I could not resist changing the T-Sql END to a proper COMMIT. Really this is for search reasons, I found hard to find in mxr where the transaction was committed, till I found it by manual inspection.
Attachment #541370 - Flags: review?(bent.mozilla)
Attachment #541370 - Flags: review?(bent.mozilla) → review?(sdwilsh)
Attachment #541370 - Flags: review?(sdwilsh) → review?(bent.mozilla)
Comment on attachment 541370 [details] [diff] [review]
patch v1.0

Review of attachment 541370 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, thanks!
Attachment #541370 - Flags: review?(bent.mozilla) → review+
Attached patch patch v1.1Splinter Review
just an unbitrot
Attachment #541370 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/01f5a405be12
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Component: DOM → DOM: IndexedDB
Target Milestone: mozilla10 → ---
Version: Trunk → unspecified
Kyle, in case you didn't notice you unset the TM field for all moved indexedDB bugs.
You need to log in before you can comment on or make changes to this bug.