Closed
Bug 666580
Opened 14 years ago
Closed 13 years ago
Use a transaction for indexedDB schema creation
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
People
(Reporter: mak, Assigned: mak)
Details
Attachments
(1 file, 1 obsolete file)
|
1.67 KB,
patch
|
Details | Diff | Splinter Review |
This may use a transaction for safety (concurrent connections) and performance (less fsyncs).
|
Assignee | |
Comment 1•14 years ago
|
||
Apart the transaction that should be pretty stright-forward, is there a reason for immediate being used only for read_write rather than for anything not read_only? I assumed version change is also a write and may like it.
And sorry, As a db lover I could not resist changing the T-Sql END to a proper COMMIT. Really this is for search reasons, I found hard to find in mxr where the transaction was committed, till I found it by manual inspection.
Attachment #541370 -
Flags: review?(bent.mozilla)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #541370 -
Flags: review?(bent.mozilla) → review?(sdwilsh)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #541370 -
Flags: review?(sdwilsh) → review?(bent.mozilla)
Comment on attachment 541370 [details] [diff] [review]
patch v1.0
Review of attachment 541370 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine, thanks!
Attachment #541370 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
just an unbitrot
Attachment #541370 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Target Milestone: --- → mozilla10
Component: DOM → DOM: IndexedDB
Target Milestone: mozilla10 → ---
Version: Trunk → unspecified
|
|
Assignee | |
Comment 6•13 years ago
|
||
Kyle, in case you didn't notice you unset the TM field for all moved indexedDB bugs.
You need to log in
before you can comment on or make changes to this bug.
Description
•