Use a transaction for indexedDB schema creation

RESOLVED FIXED

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.67 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
This may use a transaction for safety (concurrent connections) and performance (less fsyncs).
(Assignee)

Comment 1

6 years ago
Created attachment 541370 [details] [diff] [review]
patch v1.0

Apart the transaction that should be pretty stright-forward, is there a reason for immediate being used only for read_write rather than for anything not read_only? I assumed version change is also a write and may like it.
And sorry, As a db lover I could not resist changing the T-Sql END to a proper COMMIT. Really this is for search reasons, I found hard to find in mxr where the transaction was committed, till I found it by manual inspection.
Attachment #541370 - Flags: review?(bent.mozilla)
(Assignee)

Updated

6 years ago
Attachment #541370 - Flags: review?(bent.mozilla) → review?(sdwilsh)
(Assignee)

Updated

6 years ago
Attachment #541370 - Flags: review?(sdwilsh) → review?(bent.mozilla)
Comment on attachment 541370 [details] [diff] [review]
patch v1.0

Review of attachment 541370 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, thanks!
Attachment #541370 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 563016 [details] [diff] [review]
patch v1.1

just an unbitrot
Attachment #541370 - Attachment is obsolete: true
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/01f5a405be12

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/01f5a405be12
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Component: DOM → DOM: IndexedDB
Target Milestone: mozilla10 → ---
Version: Trunk → unspecified
(Assignee)

Comment 6

5 years ago
Kyle, in case you didn't notice you unset the TM field for all moved indexedDB bugs.
You need to log in before you can comment on or make changes to this bug.