Closed Bug 666654 Opened 8 years ago Closed 8 years ago

split eventutils.js functions that are chrome only into chromeutils.js

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla8

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

(Whiteboard: [specialpowers])

Attachments

(1 file, 1 obsolete file)

in eventutils.js we have many functions which are only used by a handful of tests.  These tests live in mochiteset-chrome and we don't need to convert these functions to run inside of SpecialPowers.
this is a first stab at this.  Looks good on try as well.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
updated patch with current state of tests and harness, looks good on try and ready for review.
Attachment #541435 - Attachment is obsolete: true
Attachment #547643 - Flags: review?(ted.mielczarek)
Comment on attachment 547643 [details] [diff] [review]
split eventutils.js functions into chromeutils.js (1.1)

Review of attachment 547643 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/tests/SimpleTest/ChromeUtils.js
@@ +1,2 @@
> +/**
> + * Synthesize a query text content event.

Please add a small comment block to the top explaining what's in this file.

::: testing/mochitest/tests/SimpleTest/EventUtils.js
@@ +695,5 @@
>  }
>  
> +/*
> + * synthesizeComposition, synthesizeText and synthesizeQuerySelectedText
> + * are only used by layout/base/tests/test_reftests_with_caret.html.

Seems like a comment that's likely to become outdated. Is it really necessary?
Attachment #547643 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/0400eef097a0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.