666654 - split eventutils.js functions that are chrome only into chromeutils.js

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in eventutils.js we have many functions which are only used by a handful of tests.  These tests live in mochiteset-chrome and we don't need to convert these functions to run inside of SpecialPowers.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: split eventutils.js functions into chromeutils.js (1.0)

this is a first stab at this.  Looks good on try as well.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: split eventutils.js functions into chromeutils.js (1.1)

updated patch with current state of tests and harness, looks good on try and ready for review.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 547643 [details] [diff] [review]
split eventutils.js functions into chromeutils.js (1.1)

Review of attachment 547643 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/tests/SimpleTest/ChromeUtils.js
@@ +1,2 @@
> +/**
> + * Synthesize a query text content event.

Please add a small comment block to the top explaining what's in this file.

::: testing/mochitest/tests/SimpleTest/EventUtils.js
@@ +695,5 @@
>  }
>  
> +/*
> + * synthesizeComposition, synthesizeText and synthesizeQuerySelectedText
> + * are only used by layout/base/tests/test_reftests_with_caret.html.

Seems like a comment that's likely to become outdated. Is it really necessary?

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/0400eef097a0