convert mochitest plugin harness code to specialpowers

RESOLVED FIXED in mozilla8

Status

Testing
Mochitest
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

unspecified
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [specialpowers])

Attachments

(1 attachment, 1 obsolete attachment)

we need to convert the functions that deal with plugins to specialpowers
Created attachment 541438 [details] [diff] [review]
convert mochitest plugins apis to specialpowers (WIP)

not ready for review, but a good first pass
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Created attachment 547644 [details] [diff] [review]
convert mochitest plugins apis to specialpowers (1.0)

simple patch ready for review.
Attachment #541438 - Attachment is obsolete: true
Attachment #547644 - Flags: review?(ted.mielczarek)
Comment on attachment 547644 [details] [diff] [review]
convert mochitest plugins apis to specialpowers (1.0)

Review of attachment 547644 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with one change.

::: testing/mochitest/specialpowers/content/specialpowers.js
@@ +258,5 @@
> +                        .getService(Components.interfaces.nsIXULAppInfo)
> +                        .QueryInterface(Components.interfaces.nsIXULRuntime);
> +
> +    return xulRuntime.XPCOMABI;
> +  },

In my patch this was an actual getter, so you could just write "SpecialPowers.XPCOMABI", which I think was cleaner. Can you change that back?
Attachment #547644 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/e9bed4a8f86e
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.