666660 - convert mochitest plugin harness code to specialpowers

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

we need to convert the functions that deal with plugins to specialpowers

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: convert mochitest plugins apis to specialpowers (WIP)

not ready for review, but a good first pass

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: convert mochitest plugins apis to specialpowers (1.0)

simple patch ready for review.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 547644 [details] [diff] [review]
convert mochitest plugins apis to specialpowers (1.0)

Review of attachment 547644 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with one change.

::: testing/mochitest/specialpowers/content/specialpowers.js
@@ +258,5 @@
> +                        .getService(Components.interfaces.nsIXULAppInfo)
> +                        .QueryInterface(Components.interfaces.nsIXULRuntime);
> +
> +    return xulRuntime.XPCOMABI;
> +  },

In my patch this was an actual getter, so you could just write "SpecialPowers.XPCOMABI", which I think was cleaner. Can you change that back?

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/e9bed4a8f86e