Closed
Bug 666660
Opened 14 years ago
Closed 14 years ago
convert mochitest plugin harness code to specialpowers
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla8
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
(Whiteboard: [specialpowers])
Attachments
(1 file, 1 obsolete file)
|
4.61 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
we need to convert the functions that deal with plugins to specialpowers
|
Assignee | |
Comment 1•14 years ago
|
||
not ready for review, but a good first pass
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•14 years ago
|
||
simple patch ready for review.
Attachment #541438 -
Attachment is obsolete: true
Attachment #547644 -
Flags: review?(ted.mielczarek)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 547644 [details] [diff] [review]
convert mochitest plugins apis to specialpowers (1.0)
Review of attachment 547644 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with one change.
::: testing/mochitest/specialpowers/content/specialpowers.js
@@ +258,5 @@
> + .getService(Components.interfaces.nsIXULAppInfo)
> + .QueryInterface(Components.interfaces.nsIXULRuntime);
> +
> + return xulRuntime.XPCOMABI;
> + },
In my patch this was an actual getter, so you could just write "SpecialPowers.XPCOMABI", which I think was cleaner. Can you change that back?
Attachment #547644 -
Flags: review?(ted.mielczarek) → review+
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•