Closed Bug 666661 Opened 8 years ago Closed 8 years ago

gfx/harfbuzz/src/hb-prive.h - compiler warnings on mac

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED WONTFIX

People

(Reporter: joey, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [build_warning])

% uname -a
Darwin banshee.local 10.7.4 Darwin Kernel Version 10.7.4: Mon Apr 18 21:24:17 PDT 2011; root:xnu-1504.14.12~3/RELEASE_X86_64 x86_64

/mozilla/sandbox/gml/gfx/harfbuzz/src/hb-private.h:216:2: warning: #warning "Could not find any system to define platform macros, library will NOT be thread-safe"
/mozilla/sandbox/gml/gfx/harfbuzz/src/hb-private.h:216:2: warning: #warning "Could not find any system to define platform macros, library will NOT be thread-safe"
/mozilla/sandbox/gml/gfx/harfbuzz/src/hb-private.h:216:2: warning: #warning "Could not find any system to define platform macros, library will NOT be thread-safe"
/mozilla/sandbox/gml/gfx/harfbuzz/src/hb-private.h:216:2: warning: #warning "Could not find any system to define platform macros, library will NOT be thread-safe"
/mozilla/sandbox/gml/gfx/harfbuzz/src/hb-private.h:216:2: warning: #warning "Could not find any system to define platform macros, library will NOT be thread-safe"
/mozilla/sandbox/gml/gfx/harfbuzz/src/hb-private.h:216:2: warning: #warning "Could not find any system to define platform macros, library will NOT be thread-safe"
/mozilla/sandbox/gml/gfx/harfbuzz/src/hb-private.h:216:2: warning: #warning "Could not find any system to define platform macros, library will NOT be thread-safe"
/mozilla/sandbox/gml/gfx/harfbuzz/src/hb-private.h:216:2: warning: #warning "Could not find any system to define platform macros, library will NOT be thread-safe"
/mozilla/sandbox/gml/gfx/harfbuzz/src/hb-private.h:216:2: warning: #warning "Could not find any system to define platform macros, library will NOT be thread-safe"
/mozilla/sandbox/gml/gfx/harfbuzz/src/hb-private.h:216:2: warning: #warning "Could not find any system to define platform macros, library will NOT be thread-safe"
/mozilla/sandbox/gml/gfx/harfbuzz/src/hb-private.h:216:2: warning: #warning "Could not find any system to define platform macros, library will NOT be thread-safe"
Whiteboard: [build_warnings]
Whiteboard: [build_warnings] → [build_warning]
harfbuzz tests for HAVE_GLIB there and mozilla configure never sets this (harfbuzz own configure does such test but this configure is unuzed when building as part of mozilla)

(for me it happens on linux x86_64 and firefox 6.0.1)
This is expected and harmless. We don't need thread-safety in harfbuzz at this point.
Perhaps take this up with Behdad, upstream. I don't think we'll be fixing this any time soon.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
I asked Jonathan on another bug to help me with adding intrinsics for OS X.
Alternatively, I can limit the warning to one time maybe.  Let me try that.
commit bd7ff1dec5b92ee59fa060e793f88499adcd8c11
Author: Behdad Esfahbod <behdad@behdad.org>
Date:   Thu Feb 23 15:06:16 2012 -0500

    Allow disabling multi-threaded support
    
    By defining HB_NO_MT.
    
    Also, only warn once per missing MT feature support.
    
    Mozilla Bug 666661 - gfx/harfbuzz/src/hb-prive.h - compiler warnings on mac
Target Milestone: --- → mozilla12
Version: unspecified → Trunk
Thanks, Behdad - we'll pick that up next time we refresh our copy of the HB code.
Target Milestone: mozilla12 → ---
You need to log in before you can comment on or make changes to this bug.