666665 - Remove isindex content code

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 541439 [details] [diff] [review]
Patch v1

>From: Ms2ger <[e-mail]>
>
>diff --git a/content/base/src/nsGkAtomList.h b/content/base/src/nsGkAtomList.h
>--- a/content/base/src/nsGkAtomList.h
>+++ b/content/base/src/nsGkAtomList.h
>@@ -474,17 +474,16 @@ GK_ATOM(insertafter, "insertafter")
> GK_ATOM(insertbefore, "insertbefore")
> GK_ATOM(instanceOf, "instanceOf")
> GK_ATOM(int32, "int32")
> GK_ATOM(int64, "int64")
> GK_ATOM(integer, "integer")
> GK_ATOM(intersection, "intersection")
> GK_ATOM(iscontainer, "iscontainer")
> GK_ATOM(isempty, "isempty")
>-GK_ATOM(isindex, "isindex")

Don't know if the HTML5 parser might need (or befit from) this. r=me if Henri signs off on this too.

Comment 2

[Henri Sivonen (:hsivonen)]

Comment on attachment 541439 [details] [diff] [review]
Patch v1

Removing this is OK. For the time being, the HTML5 parser makes an "isindex" atom exist by other means.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/0f00661af740

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

For documentation, note that we haven't created nsIDOMHTMLIsIndexElements since bug 611352. Checks for "node instanceof nsIDOMHTMLIsIndexElement" can be replaced with "node instanceof nsIDOMHTMLInputElement".

Comment 5

[Kris Maglione [:kmag]]

Added notes to Firefox 8 release notes. The interface is not documented elsewhere on MDC.

https://developer.mozilla.org/en/Firefox_8_for_developers#section_2