Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Remove isindex content code

RESOLVED FIXED in mozilla8

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

({dev-doc-complete})

Trunk
mozilla8
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 541439 [details] [diff] [review]
Patch v1
Flags: in-testsuite-
Attachment #541439 - Flags: review?(jonas)
Comment on attachment 541439 [details] [diff] [review]
Patch v1

>From: Ms2ger <ms2ger@gmail.com>
>
>diff --git a/content/base/src/nsGkAtomList.h b/content/base/src/nsGkAtomList.h
>--- a/content/base/src/nsGkAtomList.h
>+++ b/content/base/src/nsGkAtomList.h
>@@ -474,17 +474,16 @@ GK_ATOM(insertafter, "insertafter")
> GK_ATOM(insertbefore, "insertbefore")
> GK_ATOM(instanceOf, "instanceOf")
> GK_ATOM(int32, "int32")
> GK_ATOM(int64, "int64")
> GK_ATOM(integer, "integer")
> GK_ATOM(intersection, "intersection")
> GK_ATOM(iscontainer, "iscontainer")
> GK_ATOM(isempty, "isempty")
>-GK_ATOM(isindex, "isindex")

Don't know if the HTML5 parser might need (or befit from) this. r=me if Henri signs off on this too.
Attachment #541439 - Flags: review?(jonas)
Attachment #541439 - Flags: review?(hsivonen)
Attachment #541439 - Flags: review+
Comment on attachment 541439 [details] [diff] [review]
Patch v1

Removing this is OK. For the time being, the HTML5 parser makes an "isindex" atom exist by other means.
Attachment #541439 - Flags: review?(hsivonen) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/mozilla-central/rev/0f00661af740
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Blocks: 674310

Updated

6 years ago
Keywords: dev-doc-needed
(Assignee)

Comment 4

6 years ago
For documentation, note that we haven't created nsIDOMHTMLIsIndexElements since bug 611352. Checks for "node instanceof nsIDOMHTMLIsIndexElement" can be replaced with "node instanceof nsIDOMHTMLInputElement".
Added notes to Firefox 8 release notes. The interface is not documented elsewhere on MDC.

https://developer.mozilla.org/en/Firefox_8_for_developers#section_2
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.