Last Comment Bug 666677 - modules/libjar/zipwriter - compiler warnings on mac
: modules/libjar/zipwriter - compiler warnings on mac
Product: Core Graveyard
Classification: Graveyard
Component: File Handling (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla9
Assigned To: Atul Aggarwal
Depends on:
Blocks: buildwarning
  Show dependency treegraph
Reported: 2011-06-23 11:28 PDT by Joey Armstrong [:joey]
Modified: 2016-06-22 12:16 PDT (History)
6 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

Patch v1 (817 bytes, patch)
2011-08-30 06:50 PDT, Atul Aggarwal
dtownsend: review+
Details | Diff | Splinter Review

Description User image Joey Armstrong [:joey] 2011-06-23 11:28:23 PDT
% uname -a
Darwin banshee.local 10.7.4 Darwin Kernel Version 10.7.4: Mon Apr 18 21:24:17 PDT 2011; root:xnu-1504.14.12~3/RELEASE_X86_64 x86_64

/mozilla/sandbox/gml/modules/libjar/zipwriter/src/nsDeflateConverter.cpp:72: warning: enumeration value 'WRAP_ZLIB' not handled in switch
Comment 1 User image Atul Aggarwal 2011-08-30 06:50:05 PDT
Created attachment 556822 [details] [diff] [review]
Patch v1
Comment 2 User image Daniel Holbert [:dholbert] (away, returning Jan 17) 2011-09-01 15:30:11 PDT
Landed on mozilla-inbound:

Atul: Thanks for the fix! In future patches, it'd be great if you could include a suggested commit message to your patches, so that whoever lands it for you can just qimport & push (after noting review if not already noted in commit message).

(basically, just "hg qref -e" when you have the patch applied in your patch queue)
Comment 3 User image Atul Aggarwal 2011-09-01 20:49:21 PDT
Thanks Daniel for pointing that out. I will take care of it in future.
Comment 4 User image :Ehsan Akhgari (in Taipei, laggy response time) 2011-09-02 08:42:55 PDT

Note You need to log in before you can comment on or make changes to this bug.