Closed
Bug 666677
Opened 13 years ago
Closed 13 years ago
modules/libjar/zipwriter - compiler warnings on mac
Categories
(Core Graveyard :: File Handling, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: joey, Assigned: atulagrwl)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
817 bytes,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
% uname -a
Darwin banshee.local 10.7.4 Darwin Kernel Version 10.7.4: Mon Apr 18 21:24:17 PDT 2011; root:xnu-1504.14.12~3/RELEASE_X86_64 x86_64
/mozilla/sandbox/gml/modules/libjar/zipwriter/src/nsDeflateConverter.cpp:72: warning: enumeration value 'WRAP_ZLIB' not handled in switch
|
Reporter | |
Updated•13 years ago
|
Whiteboard: [build_warnings]
|
||
Updated•13 years ago
|
Whiteboard: [build_warnings] → [build_warning]
|
|
||
Updated•13 years ago
|
Blocks: buildwarning
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #556822 -
Flags: review?
|
||
Updated•13 years ago
|
Attachment #556822 -
Flags: review? → review?(dtownsend)
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → atulagrwl
|
||
Updated•13 years ago
|
Attachment #556822 -
Flags: review?(dtownsend) → review+
|
|
||
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 2•13 years ago
|
||
Landed on mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/1a78f5c53b58
Atul: Thanks for the fix! In future patches, it'd be great if you could include a suggested commit message to your patches, so that whoever lands it for you can just qimport & push (after noting review if not already noted in commit message).
See:
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
(basically, just "hg qref -e" when you have the patch applied in your patch queue)
Keywords: checkin-needed
Version: unspecified → Trunk
|
|
Assignee | |
Comment 3•13 years ago
|
||
Thanks Daniel for pointing that out. I will take care of it in future.
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•