JavaScript strict warning: bookmarks.js: setting a property that has only a getter

RESOLVED FIXED in mozilla7

Status

Cloud Services
Firefox Sync: Backend
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: zpao, Assigned: zpao)

Tracking

unspecified
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed in services][qa-])

Attachments

(1 attachment)

JavaScript strict warning: resource://services-sync/engines/bookmarks.js, line 400: setting a property that has only a getter

The guilty code is trying to set a property in the getter.
Created attachment 541447 [details] [diff] [review]
Patch v0.1

I was seeing this on first setup sync (wipe & setup new sync key, sync up). But no more.
Assignee: nobody → paul
Attachment #541447 - Flags: review?(philipp)
Comment on attachment 541447 [details] [diff] [review]
Patch v0.1

Thanks! We'll land this on s-c.
Attachment #541447 - Flags: review?(philipp) → review+
http://hg.mozilla.org/services/services-central/rev/0b5fd6630964
Status: NEW → ASSIGNED
Whiteboard: [fixed in services][qa-]
Push this follow-up to make test_bookmark_engine.js pass again:
http://hg.mozilla.org/services/services-central/rev/40866f5a86d2
http://hg.mozilla.org/mozilla-central/rev/0b5fd6630964
http://hg.mozilla.org/mozilla-central/rev/40866f5a86d2
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.