666721 - Fix styling of in-content attachment name

Status: NEW

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch

Stanimir Stamenkov noted in m.d.a.seamonkey:
-------
SeaMonkey 2.1 changes the display of attachments inline a bit and there seems to be incomplete styling of the attachment name:

SeaMonkey 2.0
http://i.imgur.com/588M7.png

The attachment names appear in gray and have a smaller type.  The source styling appears to come from "chrome://messagebody/skin/messageBody.css":

..mimeAttachmentName {
  color: gray;
  font-size: 80%;
}

SeaMonkey 2.1
http://i.imgur.com/1znm9.png

The attachment names appears in regular content style.  The '.mimeAttachmentName' rule seems replaced with:

..mimeAttachmentHeaderName {
  color: gray;
  font-size: 80%;
}

It would be nice if .mimeAttachmentName including ..mimeAttachmentFile and .mimeAttachmentSize get styled with the given declarations so they get visually distinct from the regular attachment content.  I also suggest using 'graytext' instead of 'gray' color so it doesn't accidentally clash with the user color scheme.
-------

This is a regression from bug 544984 which replaced the .mimeAttachmentName rule by a .mimeAttachmentHeaderName rule when it should in fact just have added to the existing one.

Comment 1

[[e-mail]]

(In reply to comment #0)
> I also suggest using
> 'graytext' instead of 'gray' color so it doesn't accidentally clash with the
> user color scheme.
I don't think we actually use system colours for the message body.

Comment 2

[[e-mail]]

(In reply to comment #0)
> This is a regression from bug 544984 which replaced the .mimeAttachmentName
> rule by a .mimeAttachmentHeaderName rule when it should in fact just have
> added to the existing one.
It's a regression, yes, but it happened because one of the occurrences of mimeAttachmentName was inadvertently overlooked and did not get renamed to mimeAttachmentHeaderName. Please file a bug on that, and then we'll look into landing the workaround on the branches.

Comment 3

[Stanimir Stamenkov]

(In reply to comment #1)
>> I also suggest using 
>> 'graytext' instead of 'gray' color so it doesn't accidentally clash with the 
>> user color scheme.
>
> I don't think we actually use system colours for the message body.

I have the preference of "Use system colors" checked so I almost always have the display using the system colors.  It is just a suggestion.  If it is not considered to be a common setup - I can live with it customizing it for me as necessary.

Comment 4

[Karsten Düsterloh]

Comment on attachment 541470 [details] [diff] [review]
patch

(Removing review request due to sr- and comment #2.)

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Reality update: Free to take.