Closed
Bug 666733
Opened 13 years ago
Closed 13 years ago
Fix logic problem in fun_getProperty
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 666587
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(1 file)
2.14 KB,
patch
|
Details | Diff | Splinter Review |
Bug 640593 seems to have messed up a little. Apparently there is never a fp nullcheck any longer. Also, the logic here: 1.106 - case FUN_CALLER: { 1.107 - vp->setNull(); 1.108 - 1.109 - StackFrame *callerframe = (fp && fp->prev()) ? js_GetScriptedCaller(cx, fp->prev()) : NULL; 1.110 - if (callerframe && !callerframe->getValidCalleeObject(cx, vp)) 1.111 + } else if (JSID_IS_ATOM(id, cx->runtime->atomState.callerAtom)) { 1.112 + if (!fp->prev()) 1.113 return false; We're returning false if there's no prev(), but we should be returning true. Also, mrbkap notes that there are tabs in this file now.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: general → bent.mozilla
Status: NEW → ASSIGNED
Attachment #541487 -
Flags: review?(jorendorff)
Comment 2•13 years ago
|
||
Whoops, we just working on this, not realizing you had already posted a patch. But I think there was another unintentional change in the original that we fixed too. Anyway, good catch.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
Updated•13 years ago
|
Attachment #541487 -
Flags: review?(jorendorff)
You need to log in
before you can comment on or make changes to this bug.
Description
•