Closed Bug 666784 Opened 12 years ago Closed 12 years ago

kNotifyData.redirectCallback in nptest.cpp is not initialized with NULL

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla7

People

(Reporter: hiro, Assigned: hiro)

Details

(Whiteboard: [inbound])

Attachments

(1 file)

fix
672 bytes, patch
jaas
: review+
Details | Diff | Splinter Review 
Actually it cause no bad infection, but should be fixed.
Attached patch fix — — Splinter Review 

        Attachment #541530 -
        Flags: review?(joshmoz)

    
    

    
  
It's a statically initialized struct, which means that unknown members are initialized to 0/null by the compiler.

    
    

    
  
(In reply to comment #2)
> It's a statically initialized struct, which means that unknown members are
> initialized to 0/null by the compiler.

I know, but it depends on compiler, isn't it?

    
  
Assignee: nobody → hiikezoe

    
    

    
  
Comment on attachment 541530 [details] [diff] [review]
fix

I'm fine with being explicit about it.

        Attachment #541530 -
        Flags: review?(joshmoz) → review+

    
  
Keywords: checkin-needed

    
    

    
  
http://hg.mozilla.org/integration/mozilla-inbound/rev/8e180685b9f3
Keywords: checkin-needed
Whiteboard: [inbound]
Version: unspecified → Trunk

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/8e180685b9f3
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7

    
    

    
  
The changes are visible in the Mozilla central repository, in nptest.cpp.
Setting resolution to Verified Fixed.
Status: RESOLVED → VERIFIED

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.