666784 - kNotifyData.redirectCallback in nptest.cpp is not initialized with NULL

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Actually it cause no bad infection, but should be fixed.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: fix

Comment 2

[Benjamin Smedberg]

It's a statically initialized struct, which means that unknown members are initialized to 0/null by the compiler.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

(In reply to comment #2)
> It's a statically initialized struct, which means that unknown members are
> initialized to 0/null by the compiler.

I know, but it depends on compiler, isn't it?

Comment 4

[Josh Aas]

Comment on attachment 541530 [details] [diff] [review]
fix

I'm fine with being explicit about it.

Comment 5

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/8e180685b9f3

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/8e180685b9f3

Comment 7

[Virgil Dicu [:virgil] [QA]]

The changes are visible in the Mozilla central repository, in nptest.cpp.
Setting resolution to Verified Fixed.