Don't show localepicker if system locale is available

VERIFIED FIXED in Firefox 7

Status

VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

Trunk
Firefox 7
Bug Flags:
in-litmus +

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 1 obsolete attachment)

813 bytes, patch
mfinkle
: review+
mfinkle
: ui-review+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Created attachment 541708 [details]
Patch

We've debated back and forth about whether or not it is worth showing the locale picker ui on firstrun when we already have the system locale available.

Android phones (at least in the US) don't include very many languages by default (mine only has en-US and en-ES). While we ship both those languages, a native Chinese/French/etc speaking user might be happy to have a choice of running their browser in a separate locale. System-locale does not necessarily indicate the users preferred locale.

I also haven't heard or seen any complaints about the UI showing.

However, in the interest or providing the best possible UX, I wanted to put up a patch to do this. Its probably that most users just ignore the locale picker anyway, and not showing the picker could make their first experience with Fennec even smoother.
(Assignee)

Comment 1

7 years ago
Created attachment 541712 [details] [diff] [review]
Patch

Whoops. Without the logging.
Assignee: nobody → wjohnston
Attachment #541708 - Attachment is obsolete: true
Attachment #541712 - Flags: review?(mark.finkle)
Comment on attachment 541712 [details] [diff] [review]
Patch

code looks ok, but we need UX to review this too and approve the change.
Attachment #541712 - Flags: review?(mark.finkle) → review+
Attachment #541712 - Flags: ui-review?(madhava)
(Assignee)

Comment 3

7 years ago
Talked with Thomas and Brian about this today. I think we are ok to go with this. We are going to add a link to about:home that only shows on firstrun and offers a chance to change your language.

If we don't have the system locale in Fennec (yet), we are going to show the localepicker, with a new link to download the system locale.
Comment on attachment 541712 [details] [diff] [review]
Patch

I am ui-r+ this change based on the emails and IRC discussions. We plan to add the "Change Language" button in about:home as well
Attachment #541712 - Flags: ui-review?(madhava) → ui-review+
(Assignee)

Updated

7 years ago
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/21735c9f4122
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7

Updated

7 years ago
Depends on: 669154
Verified Fixed
Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110704 Firefox/7.0a1 Fennec/7.0a1

Please see dependency.
Status: RESOLVED → VERIFIED

Updated

7 years ago
Flags: in-litmus?(aaron.train)
Litmus: https://litmus.mozilla.org/show_test.cgi?&id=22926
Flags: in-litmus?(aaron.train) → in-litmus+
You need to log in before you can comment on or make changes to this bug.