Closed
Bug 667056
Opened 12 years ago
Closed 12 years ago
JS_SetFunctionCallback missing calls
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: sfink, Assigned: sfink)
Details
(Whiteboard: [fixed-in-tracemonkey], wanted-standalone-js)
Attachments
(1 file)
7.54 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
The call to Probes::enterJSFun was moved into ScriptDebugPrologue (bug 636296), which is only called in debug mode. Probes are not debug-specific, so this is incorrect. In particular, if you configure with --enable-trace-jscalls, you will miss many calls.
Assignee | ||
Comment 1•12 years ago
|
||
1. Move Probes::enterJSFun from ScriptDebugPrologue to ScriptPrologue 2. Make the opposite change for JM: it was calling ScriptDebugPrologue if the Probes:: stuff wanted to be triggered, but it should really only call the Probes:: stuff. This patch additionally stops calling the functionCallback when Probes::startExecution is hit, because this change causes us to get a enterJSFun hit for the top-level script anyway (and it was messy besides.)
![]() |
||
Comment 2•12 years ago
|
||
Comment on attachment 541810 [details] [diff] [review] Pull the probes:: calls back out of DebugPrologue Review of attachment 541810 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsinterpinlines.h @@ +358,1 @@ > if (cx->compartment->debugMode) Since Probes and Debug stuff kindof lump together in my mind, can you take out the intervening whitespace here and for exit too?
Attachment #541810 -
Flags: review?(luke) → review+
Assignee | ||
Comment 3•12 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/970c23eec1ae (with the suggested whitespace changes)
Whiteboard: [fixed-in-tracemonkey]
Comment 4•12 years ago
|
||
cdleary-bot mozilla-central merge info: http://hg.mozilla.org/mozilla-central/rev/970c23eec1ae
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Updated•12 years ago
|
Whiteboard: [fixed-in-tracemonkey] → [fixed-in-tracemonkey], wanted-standalone-js
You need to log in
before you can comment on or make changes to this bug.
Description
•