JS_SetFunctionCallback missing calls

RESOLVED FIXED in mozilla8

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

unspecified
mozilla8
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-tracemonkey], wanted-standalone-js)

Attachments

(1 attachment)

The call to Probes::enterJSFun was moved into ScriptDebugPrologue (bug 636296), which is only called in debug mode. Probes are not debug-specific, so this is incorrect. In particular, if you configure with --enable-trace-jscalls, you will miss many calls.
Created attachment 541810 [details] [diff] [review]
Pull the probes:: calls back out of DebugPrologue

1. Move Probes::enterJSFun from ScriptDebugPrologue to ScriptPrologue
2. Make the opposite change for JM: it was calling ScriptDebugPrologue if the Probes:: stuff wanted to be triggered, but it should really only call the Probes:: stuff.

This patch additionally stops calling the functionCallback when Probes::startExecution is hit, because this change causes us to get a enterJSFun hit for the top-level script anyway (and it was messy besides.)
Assignee: general → sphink
Status: NEW → ASSIGNED
Attachment #541810 - Flags: review?(luke)

Comment 2

8 years ago
Comment on attachment 541810 [details] [diff] [review]
Pull the probes:: calls back out of DebugPrologue

Review of attachment 541810 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsinterpinlines.h
@@ +358,1 @@
>      if (cx->compartment->debugMode)

Since Probes and Debug stuff kindof lump together in my mind, can you take out the intervening whitespace here and for exit too?
Attachment #541810 - Flags: review?(luke) → review+
http://hg.mozilla.org/tracemonkey/rev/970c23eec1ae

(with the suggested whitespace changes)
Whiteboard: [fixed-in-tracemonkey]
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8

Updated

8 years ago
Whiteboard: [fixed-in-tracemonkey] → [fixed-in-tracemonkey], wanted-standalone-js
You need to log in before you can comment on or make changes to this bug.