667058 - Stray ASCII DEL (0x7F) glyph in the window title, due to misuse of "" in a Makefile

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: screenshot

See the attachment for the symptom.

This is caused by the fix for bug 649373, specifically:

  +PRE_RELEASE_SUFFIX := ""

That sets the suffix to a literal "" not an empty string.  This ends up with a -DPRE_RELEASE_SUFFIX = """" when calling the pre-processor which somehow results in ASCII DEL being inserted into browser.xul.  Not entirely sure why just yet.  Also, I'm not sure why we hit this bug but m.o builds didn't.  Possibly due to newer autotools?

The simple fix is from Bill Nottingham <[e-mail]>

-PRE_RELEASE_SUFFIX := ""
+PRE_RELEASE_SUFFIX :=

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch, from Bill Nottingham

Comment 2

[:Gavin Sharp [email: [e-mail]]]

There's another instance of this in browser/installer/windows/Makefile.in.

Comment 3

[Christopher Blizzard (:blizzard)]

Oh man, that is pretty awesome.

Comment 4

[Ionut Biru]

do you guys wait for bug #649587 for proper fixing or waiting for a better patch?

Comment 5

[Christopher Chittleborough]

This *might* be a problem with make-jars.pl and/or preprocessor.pl. I hope.

The good news is that (AFAIK) those Perl scripts have now been replaced by JarMaker.py and Preprocessor.py. Better yet, the latter was changed by http://hg.mozilla.org/mozilla-central/rev/9f5e80c5cae2 (see bug #439050) to look for -Dname="value" and treat it as -Dname=value (ie., remove the double quotes from before and after the value).

Has anyone seen this problem with a Firefox built using the Python scripts?

Comment 6

[Kim Moir [:kmoir] ET]

Triaging, old bug, not applicable, closing.