667077 - btoa function is not defined in frame scripts

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

+++ This bug was initially created as a clone of Bug #622224 +++

The "btoa" function running in the frame script (see bug URL) sometimes works and sometimes is undefined.

I haven't found the right pattern yet. The function is called from a OnLocationChange listener, and when I open a url with a <iframe> (like "data:text/html,<iframe>" ) it always happen, but I'm not sure that's the only case.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Debug

This is spewing a warning in debug builds so this should make it easier to see where that's coming from

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

FWIW, you might be able to work around this by using |content.btoa()|.  That wouldn't have worked for bug 622224.  But we should fix this anyway.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 541817 [details] [diff] [review]
Debug

Try cjones' idea too

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Attachment: Add atob/btoa to frame scripts

the warning is flooding the logs during some mochi-4, and we can't use content.btoa because that could be an untrusted function.
This happens because btoa is not part of the frame script context, and I think the function call never worked there. cjones said that the real solution is to add atob/btoa for frame scripts, this is a patch for it.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Attachment: Add atob/btoa to frame scripts

with uuid rev'ed

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 541924 [details] [diff] [review]
Add atob/btoa to frame scripts

Could you add nsContentUtils::Btoa/Atob, which would do
exactly what nsGlobalWindow::Btoa/Atob do now and call the nsContentUtils
methods in nsGlobalWindow and in message manager code.

And this needs some tests.

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This makes me wonder if http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/bindings/browser.js#366 has ever worked.  I noticed it spamming while running the mochitest-browser-chrome tests.

Comment 8

[Josh Matthews [:jdm]]

Attachment: Add atob/btoa to frame scripts

Scratch that itch.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 548556 [details] [diff] [review]
Add atob/btoa to frame scripts

Could you remove Is8bit from nsGlobalWindow and expose also it
in nsContentUtils?

Comment 10

[Josh Matthews [:jdm]]

Attachment: Add atob/btoa to frame scripts.

Darn, forgot to save nsGlobalWindow after removing Is8Bit last time.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 548561 [details] [diff] [review]
Add atob/btoa to frame scripts.


>+    // for each character in this chunk...
>+    while (c < fragmentEnd)
>+      if (*c++ & EIGHT_BIT)
>+        return PR_FALSE;

I know you're just moving code, but could you please
fix the coding style.
while (expr) {
  stmt;
}
and same with if

Comment 12

[Josh Matthews [:jdm]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/91aa25a681a5

Comment 13

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/91aa25a681a5

Comment 14

[Nickolay_Ponomarev]

dev-doc-needed: I didn't find existing documentation for frame scripts, but there should be a page listing the things (like globals, events) available to frame scripts.

Comment 15

[Josh Matthews [:jdm]]

That would be https://developer.mozilla.org/en/The_message_manager . Good point.

Comment 16

[Nickolay_Ponomarev]

Thanks! (Tweaked that page to mention "frame scripts", since googling that term doesn't find many useful results right now.)