667151 - Documentation error in tabs attach example

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: Documentation, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The example for the tabs attach method uses |postMessage| where it should be |self.postMessage|.

This slowed me down (and probably others) since this example code is likely to be copy/pasted as simple scaffolding code.

Comment 1

[Will Bamberg [:wbamberg]]

Attachment: Replace tab.attach example

I ended up replacing the example there, since the existing example gave you an error if you just copy-paste-cfx-run it, as it expects the page to contain an element with ID "#my-watched-element".

This example doesn't use postMessage at all, but hopefully it's pretty obvious you can postMessage from the content script, and the example earlier (line 47) includes that.

Comment 2

[Brian Warner [:warner :bwarner]]

Comment on attachment 544627 [details] [diff] [review]
Replace tab.attach example

looks good! much simpler.

Comment 3

[Will Bamberg [:wbamberg]]

Landed in: https://github.com/mozilla/addon-sdk/commit/f1ea4beb42c26e2384ff6bec26b50156e20b68cf