66719 - Outliner is behaving weird when all columns are hidden

Status: RESOLVED FIXED

(Core :: XUL, defect, P4)

Description

[Håkan Waara]

Mozilla/5.0 (Windows; U; Win98; en-US; m18) Gecko/20010126

NOTE: This is affecting *ALL* trees with the little tree-customizing-control all
over the Mozilla product!

To reproduce:

1. Find a treecontrol with editable columns (i.e the little button to the right
in the columns field)
2. Click on that little button to pop up the menu with available columns to
hide/show
3. Uncheck all menuitems
4. Watch the tree's behavior.

Now the tree's fields are all blank, but they are still selectable. That little
control is automatically moved to the left in the column-field and the rest is
just white.

This is not the expectable behaviour. I would the little control to disable the
last item which is checked to prevent the user from unchecking every column.

Comment 1

[[e-mail]]

Confirmed even with the 2001011920 builds.  

OS: Win2k SP1
Moz Build: 2001011920 Win32 Talkback
User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; m18) Gecko/20010119

Comment 2

[Jure Repinc (JLP)]

Same here. Also tried in MailNews and the same happens.
Mozilla 2001012610 on Windows 2000 SP1 on PC.

Comment 3

[Jesse Ruderman]

*** Bug 66831 has been marked as a duplicate of this bug. ***

Comment 4

[Jesse Ruderman]

From the dup:

- This can trigger bug 66832, "column picker menu always appears left of 
widget", which makes it a little tricky to re-add columns if the column picker 
ends up near the left edge of the screen.

- Some columns in the mail thread pane have fixed width.  Removing all but 
these items causes similar strange behavior.

Comment 5

[Peter Trudelle]

This was fixed for trees (can't deselect the primary column). But need to make
this is done for outliner. 

Comment 6

[David Hyatt]

We should just not allow the primary column to be hidden.  It shouldn't even 
show up in the column picker's list.  This can be done by patching the JS inside 
the column picker's XBL.

Reassigning to dr.

Comment 7

[Dan Rosen]

Attachment: Outliner column picker popupmenu builder should ignore primary column

Comment 8

[Paul Chen]

looks good to me, r=pchen

Comment 9

[Dan Rosen]

hyatt: need sr

Comment 10

[David Hyatt]

sr=hyatt

Comment 11

[Dan Rosen]

hm. i have a merge conflict with sspitzer's fix for bug 74473. the conflict is
trivial to resolve, but i'm not certain that seth's fix is right. checking...

Comment 12

[Dan Rosen]

Attachment: updated patch. not sure sspitzer did the right thing, but whatever.

Comment 13

[Dan Rosen]

fixed (cvs rev 1.14)