667253 - purge_builds can't clean up on-change builds from mozilla-release

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Nick Thomas [:nthomas] (UTC+12)]

From bug 667249. There was a rel-lnx-dbg dir on that slave, from an on-change build of the mozilla-releases/ repo. When we clear enough disk space for the new build we call this
  purge_builds.py -s 6 -n info -n 'rel-*' .. /scratchbox/users/cltbld/home/cltbld/build
so it's not allowed to remove that on-change build. It should be. The release builds are in rel-rel-... dirs.

Comment 1

[[e-mail] (:bhearsum)]

I'll take care of this.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: don't shorten "mozilla" to nothing

The simple way to fix this is not shortening "mozilla" to nothing. This will give us a one time hit in that anything with "mozilla" in its name will end up being a full build. I'll also have to go around and delete the existing "rel" builddirs by hand once this lands.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 542481 [details] [diff] [review]
don't shorten "mozilla" to nothing

Shame about the clobber, but perhaps lets go for broke and add some mappings for alder/holly/larch/system/accessibility/inbound/devtools/services/private-browsing/any other branches created since this was setup. Just watch out for name collisions up to the first '-'.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to comment #3)
> Comment on attachment 542481 [details] [diff] [review] [review]
> don't shorten "mozilla" to nothing
> 
> Shame about the clobber, but perhaps lets go for broke and add some mappings
> for
> alder/holly/larch/system/accessibility/inbound/devtools/services/private-
> browsing/any other branches created since this was setup. Just watch out for
> name collisions up to the first '-'.

Will do.

Comment 5

[[e-mail] (:bhearsum)]

Attachment: patch as landed

Here's the version I landed, with all the branches you mentioned added to it.

Comment 6

[[e-mail] (:bhearsum)]

This made it to production today. It ended up burning any running builds (but not tests) for any branches affected by the name changes, because they took effect mid-build instead of in the next one. That was 20-30 builds total, all of which I manually retriggered.

I also went around to all of the build machines and deleted rel-{{lnx,osx}{64,},w32}.