Closed Bug 667323 Opened 8 years ago Closed 8 years ago

Right-clicking on a video element (with controls enabled) causes playback to toggle

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla7

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

Right-click is triggering the toggling of play/pause on the video element due to the implementation of bug 518008.
See Also: → 518008
We switched to using a spacer because we already provide accessibility to the play/pause button through other means.

To fix this bug, I think we will have to switch back to using a button so the event doesn't fire on a right-click.
Please disregard comment 1. I have it working with the spacer.
The click handler now checks for only left-clicks.
Assignee: nobody → jwein
Status: NEW → ASSIGNED
Attachment #542301 - Flags: review?(gavin.sharp)
Attachment #542301 - Flags: review?(gavin.sharp) → review+
Can you land this for me Gavin?
https://hg.mozilla.org/integration/mozilla-inbound/rev/c04708b8007f
Flags: in-testsuite-
OS: Windows 7 → All
Hardware: x86 → All
http://hg.mozilla.org/mozilla-central/rev/c04708b8007f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
No longer depends on: 668398
Hi.
Any video will do to verify this?
Thanks
(In reply to Vlad [QA] from comment #7)
> Hi.
> Any video will do to verify this?
> Thanks

This bug only occurred with HTML5 <video> when controls were enabled.
Thanks Jared for the hint.
I've verified this using an html5 video in normal mode, stretch mode and full screen and the right-click isn't triggering the toggling of play/pause anymore.

Verified on Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0 beta 3

Setting resolution to Verified Fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.