Closed Bug 667391 Opened 13 years ago Closed 13 years ago

Restoring to default toolbar state changes to text below icons

Categories

(Thunderbird :: Toolbars and Tabs, defect)

Product:
Thunderbird
Component:
Toolbars and Tabs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird6 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 7.0
Tracking Flags:
Tracking Status
thunderbird6 --- fixed

People

(Reporter: squib, Assigned: squib)

References

(
URL
)

Details

Attachments

(1 file)

Add defaultlabelalign="end" to toolboxes
1.61 KB, patch
bwinton
: review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review 
For the main toolbars (that is, anything except the message header toolbar), restoring to the default set will cause the icons to change to "Icons and Text" instead of "Icons Beside Text". That's not right, and can make things look really bad (see URL courtesy of Asa Dotzler). This is just a simple case of someone forgetting to add defaultlabelalign="end" to the toolbox.

:bwinton, I hope I'm not inundating you with too many reviews. :) Feel free to reassign if need be.
Attachment #542099 - Flags: review?(bwinton)
OS: Linux → All
Hardware: x86_64 → All
Blocks: 667241
Comment on attachment 542099 [details] [diff] [review]
Add defaultlabelalign="end" to toolboxes

This seems fine to me, although I admit I haven't tested it…
Attachment #542099 - Flags: review?(bwinton) → review+
Comment on attachment 542099 [details] [diff] [review]
Add defaultlabelalign="end" to toolboxes

Requesting approval for 6.0...
Attachment #542099 - Flags: approval-comm-aurora?
Checked in: http://hg.mozilla.org/comm-central/rev/2df0e948f73b
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
Attachment #542099 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: