667471 - Certificate view does not pretty print names of ECDSA with SHA-2 algorithms

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[David Cooper]

Attachment: Patch to pretty print names of ECDSA with SHA-2 algorithms

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Build ID: 20110413222027

Steps to reproduce:

Use the Details tab of certificate viewer to look at the Certificate Signature Algorithm of a certificate signing using ECDSA with SHA-256, SHA-384, or SHA-512.


Actual results:

Field value shows the OID of the signature algorithm.  For example,

   Object Identifier (1 2 840 10045 4 3 2)


Expected results:

Field value should have displayed signature algorithm in a user friendly manner:

   ANSI X9.62 ECDSA Signature with SHA256

Comment 1

[:Cykesiopka]

Attachment: bug667471_pretty-print-ecdsa-sha2-algo-certviewer_by-David-Cooper_v1.patch

This is David Cooper's patch updated to current trunk.
I've verified via manual testing that the patch works.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecc2f2b1e9ca

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8584955 [details] [diff] [review]
bug667471_pretty-print-ecdsa-sha2-algo-certviewer_by-David-Cooper_v1.patch

Review of attachment 8584955 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 3

[:Cykesiopka]

On behalf of David Cooper: Thanks for the review!

(Try push is in Comment 1)

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d66b0fe45158

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d66b0fe45158