667492 - Please update tinderbox-stage for bug 667266

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Phil Ringnalda (:philor)]

Please update tinderbox-stage.m.o for bug 667266, so we can stop producing VXML that would play audio files from an interior decorator's brochureware site if not for the fact that the files aren't there and nothing can consume VXML 1.0. Thanks!

Comment 1

[Dumitru Gherman [:dumitru]]

There is an error with the Makefile. Here are the logs:

[root@dm-webtools04 tinderbox-src]# cvs up -dP
? memory-after.log
? memory-before.log
? memory-compare.log
cvs update: Updating .
M Makefile
RCS file: /cvsroot/mozilla/webtools/tinderbox/addnote.cgi,v
retrieving revision 1.28
retrieving revision 1.29
Merging differences between 1.28 and 1.29 into addnote.cgi
addnote.cgi already contains the differences between 1.28 and 1.29
RCS file: /cvsroot/mozilla/webtools/tinderbox/processbuild.pl,v
retrieving revision 1.75
retrieving revision 1.76
Merging differences between 1.75 and 1.76 into processbuild.pl
processbuild.pl already contains the differences between 1.75 and 1.76
P showbuilds.cgi
P showbuilds.pl
cvs update: Updating examples


[root@dm-webtools04 tinderbox-src]# make
/sbin/service sendmail stop
Shutting down sm-client:                                   [  OK  ]
Shutting down sendmail:                                    [  OK  ]
mkdir -p /var/www/webtools/tinderbox/examples
set -e ; \
        for I in Backwards.pm cvsquery.pl ep_mac.pl ep_unix.pl ep_unittest.pl ep_windows.pl get_line.pl header.pl showbuilds.pl tbglobals.pl Empty.html faq.html index.html examples/buildit.config examples/mozilla-unix.pl examples/mozilla-windows.pl  addnote.cgi admintree.cgi buildwho.pl clean.pl checksetup.pl doadmin.cgi scrape.pl showbuilds.cgi showlog.cgi warnings.pl  handlemail.pl processbuild.pl ; do \
          echo Installing $I && \
          sed -e s#/usr/bin/perl#/usr/bin/perl#g \
              -e s#@CVSROOT@#/cvsroot#g \
              -e s#@DATA_DIR@#/var/www/webtools/tinderbox/data#g \
              -e s#@TINDERBOX_DIR@#/var/www/webtools/tinderbox#g \
              -e s#@SETUID_PATH@#'/usr/bin:/bin'#g \
              $I > /var/www/webtools/tinderbox/$I && \
           chmod 644 /var/www/webtools/tinderbox/$I; \
        done
Installing Backwards.pm
Installing cvsquery.pl
Installing ep_mac.pl
Installing ep_unix.pl
Installing ep_unittest.pl
Installing ep_windows.pl
Installing get_line.pl
Installing header.pl
Installing showbuilds.pl
Installing tbglobals.pl
Installing Empty.html
Installing faq.html
Installing index.html
Installing examples/buildit.config
Installing examples/mozilla-unix.pl
Installing examples/mozilla-windows.pl
Installing addnote.cgi
Installing admintree.cgi
Installing buildwho.pl
Installing clean.pl
Installing checksetup.pl
Installing doadmin.cgi
Installing scrape.pl
Installing showbuilds.cgi
Installing showlog.cgi
Installing warnings.pl
Installing handlemail.pl
Installing processbuild.pl
set -e ; \
        for I in 1afi003r.gif star.gif ; do \
          echo Installing $I && \
          cp $I /var/www/webtools/tinderbox && \
          chmod 644 /var/www/webtools/tinderbox/$I; \
        done
Installing 1afi003r.gif
Installing star.gif
mkdir -p /var/www/webtools/tinderbox/data/bad
mkdir: `/var/www/webtools/tinderbox/data/bad' exists but is not a directory
make: *** [install] Error 1

Comment 2

[Amy Rich [:arr] [:arich]]

On irc, bear said that the bad directory was removed last week in effort to speed up backups.  Obviously there's a process that's writing to this directory because there was a mail message file there.  This caused the make to fail.  I have relocated the offending file to /var/www/webtools/tinderbox/data/bad.tmp and rerun the make.  This time there were no errors.

Bear does not have the time to look at modifying the scripts that handle the incoming mail, so this will stay as is for now.

Comment 3

[Phil Ringnalda (:philor)]

http://mxr.mozilla.org/mozilla/source/webtools/tinderbox/processbuild.pl#128 with the handy http://mxr.mozilla.org/mozilla/source/webtools/tinderbox/processbuild.pl#120 right above it as an example of how to just throw them on the floor instead of keeping them.

Comment 4

[Phil Ringnalda (:philor)]

Well, tinderbox-stage seemed to be doing exactly what I expected my patch to do on Friday afternoon, and it now seems to be pretty thoroughly broken, but I've got no way of knowing how or by what or whether that's my fault.

Comment 5

[Dumitru Gherman [:dumitru]]

So this is all set? Can I close this bug now? Or re-assign to someone else to fix the Makefile?

Comment 6

[Phil Ringnalda (:philor)]

The operation was a success, shame the patient died :)