667497 - Add documents' element size to documents' size computation

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 1

[Boris Zbarsky [:bzbarsky]]

This should probably be (or become) virtual, because we'll need to address text and attr storage at some point.

Comment 2

[Mounir Lamouri (:mounir)]

(In reply to comment #1)
> This should probably be (or become) virtual, because we'll need to address
> text and attr storage at some point.

Sure. But not needed for the moment.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 542181 [details] [diff] [review]
Patch v1

s/PRInt64/size_t/ as mentioned in other related bugs.

r=jst

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to comment #3)
> Comment on attachment 542181 [details] [diff] [review] [review]
> Patch v1
> 
> s/PRInt64/size_t/ as mentioned in other related bugs.
> 
> r=jst

I'm going to keep PRInt64 as long as the memory reporter interface is going to require it.

Comment 5

[Mounir Lamouri (:mounir)]

http://hg.mozilla.org/mozilla-central/rev/bfe78e7bfa5d

Comment 6

[Ioana (away)]

Fix visible in the /content/base/src/nsDocument.cpp file:

    3.12 +PRInt64
    3.13 +nsIDocument::SizeOf() const
    3.14 +{
    3.15 +  PRInt64 size = sizeof(*this);
    3.16 +
    3.17 +  for (nsIContent* node = GetFirstChild(); node;
    3.18 +       node = node->GetNextNode(this)) {
    3.19 +    size += node->SizeOf();
    3.20 +  }
    3.21 +
    3.22 +  return size;
    3.23 +}
    3.24 +