667525 - Base the initial "Other" zoom level on a pref rather than a property

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, enhancement)

Description

[rsx11m]

For the assumed case that bug 621823 removes the "values" property for the zoom levels in the View > Zoom menu (or independent thereof), valueOther would be the only numerical value remaining in the viewZoomOverlay.properties.

That value is identical to zoom.maxPercent, thus it could be simply taken from the pref rather than having to maintain another property value which doesn't need localization. Also, this would be a feedback to the user about the maximum zoom value that can be entered into this field.

Comment 1

[rsx11m]

Attachment: Use zoom.maxPercent instead [Checkin: comment 7]

This is against current comm-central, thus would be bitrotted by either the favored patch in bug 621823 or by bug 667529, but is trivial to unbitrot.

Comment 2

[Robert Kaiser]

It should not display the max level, it should display whatever is used right now if it's a level other then the ones listed in that menu.

Comment 3

[rsx11m]

KaiRo, this bug is about where to get the *initial* value for the "Other" menu entry from, it will still display whatever the user entered if that option is utilized. The patch doesn't change anything from the user's point of view if neither of the preferences are modified (valueOther==zoom.maxPercent default).

Comment 4

[Robert Kaiser]

ah, ok, sorry then.

Comment 5

[rsx11m]

Attachment: Patch after bug 621823

This is functionally the same patch but applies after attachment 541143 [details] [diff] [review] to simplify testing. It is also neutral relative to bug 667529.

Comment 6

[rsx11m]

Thanks Neil.

Push for attachment 542211 [details] [diff] [review] on trunk please, unless bug 621823 checks in first, in which case it's attachment 542931 [details] [diff] [review] instead.

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 542211 [details] [diff] [review]
Use zoom.maxPercent instead [Checkin: comment 7]

http://hg.mozilla.org/comm-central/rev/77c0f9cf803d