Closed
Bug 667726
Opened 13 years ago
Closed 13 years ago
bad query for getting the timestamps
Categories
(Cloud Services Graveyard :: Server: Sync, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tarek, Assigned: tarek)
Details
Attachments
(1 file, 2 obsolete files)
|
3.15 KB,
patch
|
telliott
:
review+
|
Details | Diff | Splinter Review |
COLLECTION_STAMPS should not use TTLs, as per https://hg.mozilla.org/services/sync-server/file/4df296e0880e/1.1/weave_storage/mysql.php#l383 also COLLECTION_MAX_STAMPS should avoid it too (PHP has the bug too) https://hg.mozilla.org/services/sync-server/file/4df296e0880e/1.1/weave_storage/mysql.php#l319
|
||
Comment 1•13 years ago
|
||
I have small confidence that this removes the ttls from the two dangerous queries. At the very least we should try this before resorting to more extreme solutions.
Attachment #542348 -
Flags: review?(tarek)
|
Assignee | |
Comment 2•13 years ago
|
||
Yes the patch was incomplete. here's a new version that fixes the calls
Attachment #542348 -
Attachment is obsolete: true
Attachment #542394 -
Flags: review?(telliott)
Attachment #542348 -
Flags: review?(tarek)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #542394 -
Attachment is obsolete: true
Attachment #542395 -
Flags: review?(telliott)
Attachment #542394 -
Flags: review?(telliott)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #542395 -
Attachment description: Yes the patch was incomplete. here's a new version that fixes the calls → Removes the ttl
|
|
||
Updated•13 years ago
|
Attachment #542395 -
Flags: review?(telliott) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
https://hg.mozilla.org/services/server-storage/rev/f38348c658c0
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•8 months ago
|
Product: Cloud Services → Cloud Services Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•