667817 - window.location object in page-mod contentscripts seems broken.

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

In the linked add-on in Builder, the contentscript runs on any page.
It logs the current page's window.location to the console.
It then shows the typeof for window.location.
It then iterates through all properties of the window.location object, logging each to the console.
After the loop finishes, it manually logs each of the properties to the console.



That should all work fine.

But it doesn't:

window.location logs the correct location.

typeof window.location is "object".

Nothing within the loop is logged. 

But all of the individual properties work when called manually.



This all works with Firebug and/or Firefox Nightly's new Scratchpad feature, for the record.

Comment 1

[Drew Willcoxon :adw]

Location objects are handled differently in some wrapper code, e.g., [1].  I don't know what's going on here, but given the other sandbox- and wrapper-related bugs Jetpack has uncovered, this might be another one.

[1] http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/wrappers/WrapperFactory.cpp#384

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Upping priority just to get this figured out, at least.

Alex, any idea?

Comment 3

[Alexandre Poirot [:ochameau]]

The proxy code is buggy when you use for..in loop.
The following code is wrong:
https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/lib/content/content-proxy.js#L758-764
I should not use Object.keys as it list only *own* enumerable properties although `enumerate` trap expect to retrieve names of all enumerable properties: own and prototype inherited ones.
Unfortunately, if I use a correct code:
  let result = [];
  for (let name in obj) {
    result.push(name);
  };
  return result;
I end up facing another bug around collection, where this for..in loop goes wrong (enumerate more items than expected)
(First bug around Collection fixed here:
https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/lib/content/content-proxy.js#L439-448 )

I definitively need to digg these Collections issues. I was not able to reduce these buggy behaviors to simple snippets. FYI, because of this, it is the only one wrapper issue that doesn't have a platform bug opened.

Comment 4

[Alexandre Poirot [:ochameau]]

Another issue has been reported around `location`.
If you change location using:
  window.location="http://mozilla.org";
Nothing happens, instead, `location` attribute is just replaced by a string.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(Pushing all open bugs to the --- milestone for the new triage system)

Comment 6

[Alexandre Poirot [:ochameau]]

I think that these issues around location have been fixed with the removal of proxies for content scripts.
Please reopen if needed.