667829 - No accesskey (keyboard shortcut) for Folder in Add Bookmark dialog

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[skierpage]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110619 Firefox/5.0 SeaMonkey/2.2
Build ID: 20110619205802

Steps to reproduce:

Press Ctrl-D or choose Bookmarks > File Bookmark...



Actual results:

Notice there's no keyboard shortcut to jump to the Folder item in the "Add Bookmark" dialog.


Expected results:

There should be a keyboard shortcut for this. The one item in the dialog that you always need to change if you organize bookmarks is the Folder.

It looks like the fix may be as simple as adding an editBookmarkOverlay.folder.accesskey in comm-central/source/suite/locales/en-US/chrome/common/bookmarks/editBookmarkOverlay.dtd , e.g. to make 'r' the accesskey (F-o-l-d are all in use):

  <!ENTITY editBookmarkOverlay.folder.label                    "Folder:">
+ <!ENTITY editBookmarkOverlay.folder.accesskey                "r">
  <!ENTITY editBookmarkOverlay.foldersExpanderDown.tooltip     "Show all the bookmarks folders">

Comment 1

[Edmund Wong (:ewong)]

I'm confirming this, plus moving version to trunk. (2.2 is string-frozen).
(And taking this.)

Comment 2

[Edmund Wong (:ewong)]

Attachment: Added accesskey (r) to Add Bookmark dialog.

Comment 3

[[e-mail]]

(In reply to comment #0)
> It looks like the fix may be as simple as adding an
> editBookmarkOverlay.folder.accesskey in
> comm-central/source/suite/locales/en-US/chrome/common/bookmarks/
> editBookmarkOverlay.dtd , e.g. to make 'r' the accesskey (F-o-l-d are all in
> use):
Although to be fair you can't actually summon both the folder picker and the feed location in the same dialog.

Comment 4

[[e-mail]]

Comment on attachment 543569 [details] [diff] [review]
Added accesskey (r) to Add Bookmark dialog.

"r" works, although I think we'd prefer "F" because it's a capital letter.

Comment 5

[Edmund Wong (:ewong)]

(In reply to comment #3)
> (In reply to comment #0)
> > It looks like the fix may be as simple as adding an
> > editBookmarkOverlay.folder.accesskey in
> > comm-central/source/suite/locales/en-US/chrome/common/bookmarks/
> > editBookmarkOverlay.dtd , e.g. to make 'r' the accesskey (F-o-l-d are all in
> > use):
> Although to be fair you can't actually summon both the folder picker and the
> feed location in the same dialog.

You mean the Folder Picker and the Feed location are mutually exculsive?
So wouldn't that mean I can use the F accesskey?

Comment 6

[Edmund Wong (:ewong)]

Attachment: Added accesskey (F) to Add Bookmark Dialog [Checked in: Comment 7]

Changed accesskey (r) to (F).

Comment 7

[Ian Neal]

Comment on attachment 544993 [details] [diff] [review]
Added accesskey (F) to Add Bookmark Dialog [Checked in: Comment 7]

http://hg.mozilla.org/comm-central/rev/31ef6d035561