Last Comment Bug 667866 - Misc stuff for reflect.js
: Misc stuff for reflect.js
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla7
Assigned To: Mounir Lamouri (:mounir)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-28 04:05 PDT by Mounir Lamouri (:mounir)
Modified: 2011-06-29 08:42 PDT (History)
1 user (show)
mounir: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (7.41 KB, patch)
2011-06-28 04:05 PDT, Mounir Lamouri (:mounir)
Ms2ger: review+
Details | Diff | Splinter Review
Patch v1.1 (6.01 KB, patch)
2011-06-29 03:41 PDT, Mounir Lamouri (:mounir)
no flags Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2011-06-28 04:05:59 PDT
Created attachment 542416 [details] [diff] [review]
Patch v1
Comment 1 :Ms2ger 2011-06-28 07:18:46 PDT
Comment on attachment 542416 [details] [diff] [review]
Patch v1

--- a/content/html/content/test/reflect.js
+++ b/content/html/content/test/reflect.js
@@ -1,19 +1,69 @@
+/* ***** BEGIN LICENSE BLOCK *****
+ * Version: MPL 1.1/GPL 2.0/LGPL 2.1
+ * ***** END LICENSE BLOCK ***** */

How about PD? <http://www.mozilla.org/MPL/boilerplate-1.1/pd-c>

+
+/**
+ * reflect.js is a collection of method which are going to help developers to
+ * test HTML attributes reflection.

"methods to test HTML attribute reflection"

+ * Each of attribute is reflected differently, depending on various parameter,

parameters

+ * see:
+ * http://www.whatwg.org/specs/web-apps/current-work/multipage/urls.html#reflecting-content-attributes-in-idl-attributes

I'd use <http://www.whatwg.org/html/#reflecting-content-attributes-in-idl-attributes>.

+ *
+ * Do not forget to add this line at the beginning of all new reflect* method:

s/all/each/

+ * ok(aAttr in aElement, aAttr + " should be an IDL attribute of this element");

And typeof :)

r=me
Comment 2 :Ms2ger 2011-06-28 07:19:22 PDT
Comment on attachment 542416 [details] [diff] [review]
Patch v1

And this
Comment 3 Mounir Lamouri (:mounir) 2011-06-29 03:41:58 PDT
Created attachment 542759 [details] [diff] [review]
Patch v1.1

Ready to be pushed.
Comment 4 Mounir Lamouri (:mounir) 2011-06-29 08:42:18 PDT
http://hg.mozilla.org/mozilla-central/rev/ffebdf4fb581

Note You need to log in before you can comment on or make changes to this bug.