Closed Bug 667866 Opened 10 years ago Closed 10 years ago

Misc stuff for reflect.js

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: mounir, Assigned: mounir)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
No description provided.
Attachment #542416 - Flags: review?(Ms2ger)
Comment on attachment 542416 [details] [diff] [review]
Patch v1

--- a/content/html/content/test/reflect.js
+++ b/content/html/content/test/reflect.js
@@ -1,19 +1,69 @@
+/* ***** BEGIN LICENSE BLOCK *****
+ * Version: MPL 1.1/GPL 2.0/LGPL 2.1
+ * ***** END LICENSE BLOCK ***** */

How about PD? <http://www.mozilla.org/MPL/boilerplate-1.1/pd-c>

+
+/**
+ * reflect.js is a collection of method which are going to help developers to
+ * test HTML attributes reflection.

"methods to test HTML attribute reflection"

+ * Each of attribute is reflected differently, depending on various parameter,

parameters

+ * see:
+ * http://www.whatwg.org/specs/web-apps/current-work/multipage/urls.html#reflecting-content-attributes-in-idl-attributes

I'd use <http://www.whatwg.org/html/#reflecting-content-attributes-in-idl-attributes>.

+ *
+ * Do not forget to add this line at the beginning of all new reflect* method:

s/all/each/

+ * ok(aAttr in aElement, aAttr + " should be an IDL attribute of this element");

And typeof :)

r=me
Comment on attachment 542416 [details] [diff] [review]
Patch v1

And this
Attachment #542416 - Flags: review?(Ms2ger) → review+
Attached patch Patch v1.1Splinter Review
Ready to be pushed.
Attachment #542416 - Attachment is obsolete: true
Flags: in-testsuite+
Whiteboard: [needs review] → [inbound]
http://hg.mozilla.org/mozilla-central/rev/ffebdf4fb581
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.