667866 - Misc stuff for reflect.js

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 542416 [details] [diff] [review]
Patch v1

--- a/content/html/content/test/reflect.js
+++ b/content/html/content/test/reflect.js
@@ -1,19 +1,69 @@
+/* ***** BEGIN LICENSE BLOCK *****
+ * Version: MPL 1.1/GPL 2.0/LGPL 2.1
+ * ***** END LICENSE BLOCK ***** */

How about PD? <http://www.mozilla.org/MPL/boilerplate-1.1/pd-c>

+
+/**
+ * reflect.js is a collection of method which are going to help developers to
+ * test HTML attributes reflection.

"methods to test HTML attribute reflection"

+ * Each of attribute is reflected differently, depending on various parameter,

parameters

+ * see:
+ * http://www.whatwg.org/specs/web-apps/current-work/multipage/urls.html#reflecting-content-attributes-in-idl-attributes

I'd use <http://www.whatwg.org/html/#reflecting-content-attributes-in-idl-attributes>.

+ *
+ * Do not forget to add this line at the beginning of all new reflect* method:

s/all/each/

+ * ok(aAttr in aElement, aAttr + " should be an IDL attribute of this element");

And typeof :)

r=me

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 542416 [details] [diff] [review]
Patch v1

And this

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Patch v1.1

Ready to be pushed.

Comment 4

[Mounir Lamouri (:mounir)]

http://hg.mozilla.org/mozilla-central/rev/ffebdf4fb581