667890 - Any localized edits made between two ready-for-l10n English revisions are removed

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P1)

Description

[Scoobidiver (away)]

A localized revision is associated to an English revision.
If there are edits based on the localized revision, they are removed when there is a new ready-for-l10n English revision.

See:
https://support.mozilla.com/fr/kb/Les%20modules%20compl%C3%A9mentaires%20sont%20d%C3%A9sactiv%C3%A9s%20apr%C3%A8s%20une%20mise%20%C3%A0%20jour%20de%20Firefox/history
https://support.mozilla.com/fr/kb/Les%20modules%20compl%C3%A9mentaires%20sont%20d%C3%A9sactiv%C3%A9s%20apr%C3%A8s%20une%20mise%20%C3%A0%20jour%20de%20Firefox/revision/15143 : The keywords added in this revision were removed when I tried to translate the new ready-for-l10n English revision.

Comment 1

[Scoobidiver (away)]

To clarify the above example:
* French revision 12157 has been based on French revision 11755 (right editor) and English revision 11844 (left editor).
* French revision 15318 has been based on French revision 12157 (right editor)(instead of 15143) and English revision 15291 (left editor).

As long as this bug is not fixed, any ready-for-localization article approvals should be postponed.

Comment 2

[Kadir Topal [:atopal]]

So, what do you mean with "If there are edits based on the localized revision". Do you mean edits *to* the localized revision?

Comment 3

[Scoobidiver (away)]

(In reply to comment #2)
> Do you mean edits *to* the localized revision?
Yes.

Comment 4

[Kadir Topal [:atopal]]

This is serious, and it looks like Bug 668609 is related indeed. 

James, can you make this a priority for 7-19? We are going to ready for l10n Firefox 6 articles in two weeks from now, and this would cause a lot of confusion.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

This may be fixed with the patch for Bug 668609. I will investigate.

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

This looks fixed to me. I just did the following on stage and it worked as expected.

1- Create new document (https://support.allizom.org/en-US/kb/test-doc), approve and mark as ready for l10n.
2- Translate to Spanish (https://support.allizom.org/es/kb/doc-prueba) and approve.
3- Create new English revision and approve w/o marking as ready for l10n.
4- Create new Spanish revision (translate page correctly shows the original english revision which was ready for l10n) and approve.
5- Create new English revision and approve as ready for l10n.
6- Go to create new Spanish revision. Verify that it is based on the revision from step 4 and that it shows the English revision from step 5.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

BTW, can comment 6 become a selenium test?

Comment 8

[Rebecca Billings [:rbillings]]

Verified that approved locale revision displays in addition to approved en-US changes. Marked this as eligible for automation.