Problem with deletions in IME when in composition mode on Honeycomb

VERIFIED FIXED in Firefox 7

Status

()

Core
Widget: Android
P2
major
VERIFIED FIXED
6 years ago
4 years ago

People

(Reporter: tarend, Assigned: m_kato)

Tracking

({inputmethod, relnote, verified-beta})

Trunk
mozilla8
All
Android
inputmethod, relnote, verified-beta
Points:
---

Firefox Tracking Flags

(firefox6 wontfix, firefox7 fixed, firefox8 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
Created attachment 542495 [details]
Screenshots and Steps to Reproduce Input Issue

Samsung kindly reported this bug to us - see all details in the attached PDF

Steps to reproduce:
(1) Install Korean IME dingulhangul from Android Market. Long press any input field and select the new Input method in the pop-up window
(2) Press “ᄅ” button (Korean consonant). Then press “ᄋ” button (Korean consonant). Press “space key", then press “backspace key” (see screenshots in attached PDF)

Result: When backspace key is tapped, both space and one consonant are removed.
Expected: Only space should be removed with the Backspace
(Reporter)

Comment 1

6 years ago
I forgot: In step (1) after installing the IME, go to Android Settings -> Select Language and keyboard menu in setting -> Check the box for the newly installed input method to activate it. Otherwise you won't be able to select it when long-tapping in an input field.

Also: I tried to reproduce, but could NOT reproduce the issue on my original 7inch Samsung Galaxy Tab running Android 2.2. Also, I could NOT reproduce on a Samsung Galaxy S (GT-I9000).
I could not reproduce using :

Mozilla/5.0 (Android; Linux armv71; rv7.0a1) Gecko/20110628 Firefox/7.0a1 Fennec/7.0a1
Device: HTC Flyer
OS: Android 2.3

Mozilla/5.0 (Android; Linux armv71; rv7.0a1) Gecko/20110628 Firefox/7.0a1 Fennec/7.0a1
Device: Thunderbolt
OS: Android 2.2

Maybe this is a honeycomb issue?  Another possibility is that maybe one of the options for the VKB/IME was toggled that is not default?

Comment 3

6 years ago
This bug can be NOT reproduce on Galaxy Tab 7 inch and Galaxy S running on version below Android 2.3.

I can find this issue when I have tested Galaxy Tab 10.1 inch and Galaxy Tab 8.9 inch running Android 3.0(Honeycom)

This issue is reproduced on all Korean IME except for Google Korean IME.
Thanks for the information, Sungwook.  It does appear to be a Honeycomb issue.  Android 3.0

I was able to reproduce with :
Mozilla/5.0 (Android; Linux armv71; rv7.0a1) Gecko/20110628 Firefox/7.0a1 Fennec/7.0a1
Device: Motorola Xoom
OS: Android 3.0

It appears that it may have to do with languages that commit such as Korean, Japanse (with Simeji) and Chinese (with Google Pinyin) on Honeycomb

Comment 5

6 years ago
yes, I think so. 
This issue is only appeared to Honeycomb with language using commit composing.
I guess the cause of this issue is come from something between Android Inputconnection and the edit of Firefox.
Changing the title since it's not just limited to Korean.
Summary: Issue with Korean Input Method dingulhangul → Issues with commit composing languages (like Korean, Japanese, Chinese) when in composition mode on Honeycomb
maybe, this is a bug of widget.
Component: General → Widget: Android
Product: Fennec → Core
QA Contact: general → android
Keywords: inputmethod

Updated

6 years ago
Summary: Issues with commit composing languages (like Korean, Japanese, Chinese) when in composition mode on Honeycomb → Problem with deletions in IME when in composition mode on Honeycomb
(Assignee)

Comment 8

6 years ago
This occurs when onTextChanged is called...
Assignee: nobody → m_kato
Hardware: ARM → All
(Assignee)

Comment 9

6 years ago
Created attachment 550288 [details] [diff] [review]
fix
(Assignee)

Updated

6 years ago
Attachment #550288 - Flags: review?(nchen)
(Assignee)

Comment 10

6 years ago
Comment on attachment 550288 [details] [diff] [review]
fix

canel due to some bugs
Attachment #550288 - Flags: review?(nchen)
(Assignee)

Comment 11

6 years ago
Created attachment 550962 [details] [diff] [review]
fix v2
Attachment #550288 - Attachment is obsolete: true
(Assignee)

Comment 12

6 years ago
Simple test step
1. Turn on dingulhangul IME
2. input abc
3. tap [Back] key

Result
"b" and "c" is removed

Expected Result
only "c" is removed.
(Assignee)

Comment 13

6 years ago
Created attachment 550964 [details] [diff] [review]
fix v2
Attachment #550962 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #550964 - Flags: review?(nchen)
Adding comment of https://bugzilla.mozilla.org/show_bug.cgi?id=672661#c6 .
Comment on attachment 550964 [details] [diff] [review]
fix v2

Thanks. Do you know why we didn't need this before? Does Honeycomb handle KEYCODE_DEL in TextKeyListener?
Attachment #550964 - Flags: review?(nchen) → review+
(Assignee)

Comment 16

6 years ago
(In reply to Jim Chen [:jchen] (mobile intern :) from comment #15)
> Comment on attachment 550964 [details] [diff] [review] [diff] [details] [review]
> fix v2
> 
> Thanks. Do you know why we didn't need this before? Does Honeycomb handle
> KEYCODE_DEL in TextKeyListener?

When press [del] on default keyboard (or most IME keyboards except to dingulhangul IME), GeckoSurface.onKeyDown() is called, then, KeyListener returns false.  So key press event is generated by sendEventToGecko().

But, when using dingulhangul IME, KeyListener calls onTextChanged, then return false.  This IME's behavior is strange.

[del] should be ignore for KeyListener and it should be handled by Gecko's editor code.
(Assignee)

Comment 17

6 years ago
Oops, previous comment is mistake.  So, please ignore comment #16.

(In reply to Jim Chen [:jchen] (mobile intern :) from comment #15)
> Comment on attachment 550964 [details] [diff] [review] [diff] [details] [review]
> fix v2
> 
> Thanks. Do you know why we didn't need this before? Does Honeycomb handle
> KEYCODE_DEL in TextKeyListener?

On all software keyboards except to dingulhangul IME, GeckoSurface.onKeyDown() is called, event flags has software keyboard flag, So key press event is generated by sendEventToGecko() without KeyListener.

But, dingulhangul IME has no software keyboard flag.  So, when using dingulhangul IME, KeyListener calls onTextChanged, then return false.  So delete becomes twice.

So we should send to Gecko directly if onKeyDown for [del].
(Assignee)

Comment 18

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/10b15bde43e4
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/10b15bde43e4
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Duplicate of this bug: 662219
Attachment #550964 - Flags: approval-mozilla-aurora?
Very simple patch. Know to fix this issue on samsung galaxy tab 10.1, which is a popular tablet, even at Mozilla.
Also fixes the same problem on the ASUS transformer tablet.
I hit this on the Samsung Galaxy Tab 10.1, default Keyboard today.  No special IME keyboard. Since this is not fixed on beta, this will need to be relnoted when we live to Market.

I dont feel its a blocker.  This works on nightly as expected.

Broken on Mozilla/5.0 (Android; Linux armv7l; rv:6.0) Gecko/20110810 Firefox/6.0 Fennec/6.0

It is verified on Nightly: Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110811 Firefox/8.0a1 Fennec/8.0a1
Status: RESOLVED → VERIFIED
tracking-fennec: --- → ?
Keywords: relnote

Updated

6 years ago
status-firefox6: --- → affected
status-firefox7: --- → affected

Comment 24

6 years ago
Comment on attachment 550964 [details] [diff] [review]
fix v2

Aurora [7] window has closed. Moving approval request to Beta.
Attachment #550964 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?

Comment 25

6 years ago
Comment on attachment 550964 [details] [diff] [review]
fix v2

Approved for mozilla-beta
Attachment #550964 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
pushed http://hg.mozilla.org/releases/mozilla-beta/rev/7e3966aece57
status-firefox6: affected → wontfix
status-firefox7: affected → fixed
status-firefox8: --- → fixed
verified-beta (works with swype, simeji, dingulhangul, and more)

Mozilla/5.0 (Android;Linux armv7I; rv:7.0) Gecko/20110824 Firefox/7.0 Fennec/7.0
7 Beta 2
Device: Toshiba Thrive
OS Android 3.1
Keywords: verified-beta
Just a note Verified aurora is not needed since the patch landed on the trunk during the previous 6 week cycle. The patch was part of the Aurora merge.
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.