66793 - UMR in nsTextFrame::GetContentAndOffsetsFromPoint(nsIPresContext *,nsPoint const&,nsIContent * *,int&,int&,int&)

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Daniel Bratell]

I ran Mozilla in Purify and among many other things I got a UMR in 
nsTextFrame::GetContentAndOffsetsFromPoint(...) at line 2846 in nsTextFrame.cpp. 
The line goes:

 =>   if (aContentOffset == mContentOffset)

Which I interpret as the member variable mContentOffset isn't initialized.

Comment 1

[Daniel Bratell]

The function is called with
if (aContentOffset == mContentOffset)
            result = resultFrame->GetContentAndOffsetsFromPoint(context,point,
            getter_AddRefs(aPos->mResultContent), aPos->mContentOffset,          
               aPos->mContentOffsetEnd, aPos->mPreferLeft);

so both involved variables are mContentOffsets.

Comment 2

[Bernd]

The function is now at line 3048. Could you provide a stack trace.

Comment 3

[Daniel Bratell]

The stack trace (the top since Purify doesn't save the complete stack and I 
hadn't changed the default depth to save):

nsTextFrame::GetContentAndOffsetsFromPoint(nsIPresContext *,nsPoint 
const&,nsIContent * *,int&,int&,int&) [nsTextFrame.cpp:2846]

nsFrame::GetNextPrevLineFromeBlockFrame(nsIPresContext *,nsPeekOffsetStruct 
*,nsIFrame *,int,signed char) [nsFrame.cpp:2774]

nsBlockFrame::HandleEvent(nsIPresContext *,nsGUIEvent *,nsEventStatus *) 
[nsBlockFrame.cpp:6561]

PresShell::HandleEventInternal(nsEvent *,nsIView *,UINT,nsEventStatus *) 
[nsPresShell.cpp:4929]

PresShell::HandleEvent(nsIView *,nsGUIEvent *,nsEventStatus *,int,int&) 
[nsPresShell.cpp:4849]

nsView::HandleEvent(nsGUIEvent *,UINT,nsEventStatus *,int,int&) [nsView.cpp:366]
    nsViewManager2::DispatchEvent(nsGUIEvent *,nsEventStatus *) 
[nsViewManager2.cpp:1518]

HandleEvent    [nsView.cpp:67]

nsWindow::DispatchEvent(nsGUIEvent *,nsEventStatus&) [nsWindow.obj:687]

nsWindow::DispatchMouseEvent(UINT,nsPoint *) [nsWindow.cpp:3948]

Comment 4

[Bernd]

The code around the call in nsFrame.cpp has been modified by mjudge. Reassigning
to him.

Comment 5

[rubydoo123]

moz0.9

Comment 6

[mjudge]

okfixed this one 
patch

66793UMR.dif

need SR

Comment 7

[anthonyd]

looking for an sr= from attinasi

Comment 8

[Marc Attinasi]

I had previously requested the diff from mjudge - I still need it to review :)
and I have no idea where to find 66793UMR.dif

Comment 9

[mjudge]

where the heck did the attachment go... attaching it again. there must be some 
bug out there with the wrong patch on it.

Comment 10

[mjudge]

foung the patch

http://bugzilla.mozilla.org/showattachment.cgi?attach_id=28400

stuck it on wrong bug. can you look at it there?

Comment 11

[Marc Attinasi]

cool - sr=attinasi

Comment 12

[mjudge]

committed

Comment 13

[Chris Petersen]

Marking verified per last comments.