UMR in nsTextFrame::GetContentAndOffsetsFromPoint(nsIPresContext *,nsPoint const&,nsIContent * *,int&,int&,int&)

VERIFIED FIXED in mozilla0.9

Status

()

P3
normal
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: bratell, Assigned: mjudge)

Tracking

Trunk
mozilla0.9
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: FIXINHAND, URL)

(Reporter)

Description

18 years ago
I ran Mozilla in Purify and among many other things I got a UMR in 
nsTextFrame::GetContentAndOffsetsFromPoint(...) at line 2846 in nsTextFrame.cpp. 
The line goes:

 =>   if (aContentOffset == mContentOffset)

Which I interpret as the member variable mContentOffset isn't initialized.
(Reporter)

Comment 1

18 years ago
The function is called with
if (aContentOffset == mContentOffset)
            result = resultFrame->GetContentAndOffsetsFromPoint(context,point,
            getter_AddRefs(aPos->mResultContent), aPos->mContentOffset,          
               aPos->mContentOffsetEnd, aPos->mPreferLeft);

so both involved variables are mContentOffsets.

Comment 2

18 years ago
The function is now at line 3048. Could you provide a stack trace.
(Reporter)

Comment 3

18 years ago
The stack trace (the top since Purify doesn't save the complete stack and I 
hadn't changed the default depth to save):

nsTextFrame::GetContentAndOffsetsFromPoint(nsIPresContext *,nsPoint 
const&,nsIContent * *,int&,int&,int&) [nsTextFrame.cpp:2846]

nsFrame::GetNextPrevLineFromeBlockFrame(nsIPresContext *,nsPeekOffsetStruct 
*,nsIFrame *,int,signed char) [nsFrame.cpp:2774]

nsBlockFrame::HandleEvent(nsIPresContext *,nsGUIEvent *,nsEventStatus *) 
[nsBlockFrame.cpp:6561]

PresShell::HandleEventInternal(nsEvent *,nsIView *,UINT,nsEventStatus *) 
[nsPresShell.cpp:4929]

PresShell::HandleEvent(nsIView *,nsGUIEvent *,nsEventStatus *,int,int&) 
[nsPresShell.cpp:4849]

nsView::HandleEvent(nsGUIEvent *,UINT,nsEventStatus *,int,int&) [nsView.cpp:366]
    nsViewManager2::DispatchEvent(nsGUIEvent *,nsEventStatus *) 
[nsViewManager2.cpp:1518]

HandleEvent    [nsView.cpp:67]

nsWindow::DispatchEvent(nsGUIEvent *,nsEventStatus&) [nsWindow.obj:687]

nsWindow::DispatchMouseEvent(UINT,nsPoint *) [nsWindow.cpp:3948]

Comment 4

18 years ago
The code around the call in nsFrame.cpp has been modified by mjudge. Reassigning
to him.
Assignee: karnaze → mjudge

Comment 5

18 years ago
moz0.9
Priority: -- → P3
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 6

18 years ago
okfixed this one 
patch

66793UMR.dif

need SR
Status: NEW → ASSIGNED
Whiteboard: FIXINHAND

Comment 7

18 years ago
looking for an sr= from attinasi

Comment 8

18 years ago
I had previously requested the diff from mjudge - I still need it to review :)
and I have no idea where to find 66793UMR.dif
(Assignee)

Comment 9

18 years ago
where the heck did the attachment go... attaching it again. there must be some 
bug out there with the wrong patch on it.
(Assignee)

Comment 10

18 years ago
foung the patch

http://bugzilla.mozilla.org/showattachment.cgi?attach_id=28400

stuck it on wrong bug. can you look at it there?

Comment 11

18 years ago
cool - sr=attinasi
(Assignee)

Comment 12

18 years ago
committed
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 13

18 years ago
Marking verified per last comments.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.