Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Add a DIR_INSTALL nsinstall shortcut, and allow $(INSTALL) to support target-specific makefiles

RESOLVED FIXED in mozilla8

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

unspecified
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-bs])

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 542619 [details] [diff] [review]
patch v1

This is primarily something I need on comm-central, but I decided to port this over to m-c too. The two are related because sometimes we'd like to recursively copy over stuff and not symlink it (at least I did!).

This built fine locally -- I've pushed to try server to see what happens.
(Assignee)

Comment 1

6 years ago
Bug 668058 is the comm-central version.
(Assignee)

Comment 2

6 years ago
Created attachment 542693 [details] [diff] [review]
patch v2

This retains the predicate TEST_INSTALLER used to use. Try server gave v1 the thumbs up, and I think this is even better :)
Attachment #542619 - Attachment is obsolete: true
Attachment #542693 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 3

6 years ago
I'm thinking something like DIR_INSTALL might be a better name, since we might either symlink it or recursively copy it.
Comment on attachment 542693 [details] [diff] [review]
patch v2

Review of attachment 542693 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/config.mk
@@ +683,2 @@
>  else
> +INSTALL_PWD     = `$(NFSPWD)`

Can you file a followup to get rid of NFSPWD? It looks like some ancient cruft that was probably only useful at Netscape or something.
Attachment #542693 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 5

6 years ago
Ted was undecided about whether to switch to DIR_INSTALL, so I went ahead.

https://hg.mozilla.org/projects/build-system/rev/aeb17d9bdc0d

(sorry for the wrong bug number -- 668058 was the comm-central version and I got confused between the two. In hindsight, I should have just filed a single bug.)
Summary: Add a RECURSIVE_INSTALL nsinstall shortcut, and allow $(INSTALL) to support target-specific makefiles → Add a DIR_INSTALL nsinstall shortcut, and allow $(INSTALL) to support target-specific makefiles
Whiteboard: [fixed-in-bs]
(Assignee)

Comment 6

6 years ago
(In reply to comment #4)
> ::: config/config.mk
> @@ +683,2 @@
> >  else
> > +INSTALL_PWD     = `$(NFSPWD)`
> 
> Can you file a followup to get rid of NFSPWD? It looks like some ancient
> cruft that was probably only useful at Netscape or something.

Filed as bug 670249.
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/mozilla-central/rev/aeb17d9bdc0d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.