668211 - [traceback] Some gallery images don't load

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P1)

Description

[James Socol [:jsocol, :james]]

Seen this from at least three images in the gallery:

https://support.allizom.org/en-US/gallery/image/4864
https://support.allizom.org/en-US/gallery/image/1058
https://support.allizom.org/en-US/gallery/image/990

Definitely doesn't happen for all images:

https://support.allizom.org/en-US/gallery/image/5447

Here's the traceback:

Traceback (most recent call last):

  File "/data/www/support.allizom.org/kitsune/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/support.allizom.org/kitsune/apps/gallery/views.py", line 244, in media
    media, media_format = _get_media_info(media_id, media_type)

  File "/data/www/support.allizom.org/kitsune/apps/gallery/views.py", line 283, in _get_media_info
    media_format = imghdr.what(media.file.path)

  File "/usr/lib64/python2.6/imghdr.py", line 12, in what
    f = open(file, 'rb')

UnicodeEncodeError: 'ascii' codec can't encode characters in position 67-74: ordinal not in range(128)

Comment 1

[Tanay Gavankar [:tgavankar]]

This issue occurs only with migrated images where the filename contains outside of ascii ranged unicode characters. 

It does not apply to new images since we rename files on upload.

Comment 2

[Tanay Gavankar [:tgavankar]]

Done in https://github.com/jsocol/kitsune/commit/d1ed65ca6.

Comment 3

[Rebecca Billings [:rbillings]]

Is there a way to force a test image through the migration process?

Comment 4

[Tanay Gavankar [:tgavankar]]

Not that I know of. I guess for verification just make sure that the images linked above don't cause a traceback.

Comment 5

[Rebecca Billings [:rbillings]]

By looking at the linked images above, traceback errors are triggered [same error as printed above], on support.allizom.org.

Comment 6

[Tanay Gavankar [:tgavankar]]

This seems to be a staging-only environment-based bug.

Opened bug 670758 to have IT look into it.

Comment 7

[Scoobidiver (away)]

Is it fixed in SUMO 2011-07-19?

Comment 8

[Tanay Gavankar [:tgavankar]]

Now it seems to be on prod too - it definitely wasn't before.

However, we are sure it's an OS specific bug, and so it's in IT's realm rather than ours.

Comment 9

[Tanay Gavankar [:tgavankar]]

Hm still seeing this on both production and staging - any updates?

Comment 10

[Kadir Topal [:atopal]]

I assume the bug this depends upon is the IT bug?

Comment 11

[James Socol [:jsocol, :james]]

(In reply to Kadir Topal [:atopal] from comment #10)
> I assume the bug this depends upon is the IT bug?

We should probably retest that bug on -stage. We're also in the process (in bug 697561) of bringing all our web servers up to RHEL6. We know this is environmental and so it may go away with the OS upgrade.

If it doesn't, we will need ITs help, as before, to try to figure it out. In the past it occurred on *some* of our web servers, even though they should have been identical.

Comment 12

[Tanay Gavankar [:tgavankar]]

With bug 670758 being resolved, I'm marking this as also RESO FIXED. Note that there's no actual code committed, so verification steps are just to make sure the pages listed above don't cause tracebacks/500s.

Comment 13

[James Socol [:jsocol, :james]]

If the fix is deployed already, we should probably put this in 01-03 instead of 01-10. #nit

Comment 14

[Tanay Gavankar [:tgavankar]]

Fair enough.

Comment 15

[Rebecca Billings [:rbillings]]

Verified all of the links above display gallery images correctly