668219 - rip out codesighs logic from buildbot and replace it with a tiny new step

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect, P3)

Description

[(not currently active) Ted Mielczarek]

In bug 659950 I implemented a much simpler replacement for our existing codesighs logic. You can now "make codesighs" in the objdir and it will print two metrics, like:
__codesize:40387084
__installersize:17112982

The first is the size in bytes of all the files we install to a user's machine, and the second is the size in bytes of the installer itself.

We should be able to rip out all the codesighs machinery from our buildbot steps and replace it with a simple "make codesighs" + a modified graph server post. bug 668216 is filed on the graph server changes necessary to add the new values.

Presumably this would be easier if my codesighs change landed on all active branches? I think I can arrange for that, since it's NPOTB.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

We currently have a single number, Z on tbpl/tinderbox, and 'Codesighs' in the graph server. How should that change/be supplemented for this ?

Comment 2

[(not currently active) Ted Mielczarek]

We'll have two numbers, I don't really know what the naming will be, but we can argue about that in bug 668216. :)

Comment 4

[Chris Cooper [:coop] (he/him)]

I'll start by adding the new measurements in addition to the existing codesighs, then we can remove codesighs at our leisure.

I made my nomenclature suggestion in bug 668216. Nothing fancy: codesize and installersize.

Comment 5

[Chris AtLee [:catlee]]

Can this be done so that we can move other build analysis logic into it as well (like num_ctors for example)?

Comment 6

[Chris Cooper [:coop] (he/him)]

(In reply to Chris AtLee [:catlee] from comment #5)
> Can this be done so that we can move other build analysis logic into it as
> well (like num_ctors for example)?

What do you mean? Batching the num_ctors step with these new ones into a logical bundle?

Comment 7

[Chris AtLee [:catlee]]

Yeah, I'd like a single buildbot step that calls out to a script or make target to generate all these stats.

Comment 8

[Chris Cooper [:coop] (he/him)]

It's pretty clear I'm not making progress on this

I can try to have a new hire or intern pick it up though. Is there any update in how people think this should be implemented?

Comment 9

[[e-mail] (:bhearsum)]

codesighs is dead