[stage] IE9 - cannot share marks via twitter or facebook

VERIFIED FIXED in 1.1

Status

Websites
markup.mozilla.org
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: mbrandt, Assigned: wenzel)

Tracking

unspecified
x86
Windows 7

Details

(Whiteboard: [stage], URL)

(Reporter)

Description

7 years ago
It appears that I'm unable to share marks via Facebook and Twitter in IE9. It appears to work fine in FF and Chrome
Steps to reproduce:
1. https://markup.allizom.org/en-US/#/linear/yNvD
2. click the Facebook or Twitter icon to share a mark

Expected:
A dialogue prompting the user through the process of sharing the mark appears.

Actual:
No Facebook or twitter prompt appears in the browser.

This is what I'm seeing in IE9's developer console:
SCRIPT87: Invalid argument
markUp_app.min.js, line 8 character 19
(Assignee)

Comment 1

7 years ago
I fixed this in:

https://github.com/mozilla/markup/commit/9dedb78

The internal window name contained spaces, which it "should" not. No browser but IE cares. I replaced it with a single word, and in my tests it works. Hasn't shown up on markup-dev yet unfortunately.
Assignee: nobody → fwenzel
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

7 years ago
Verified... IE9 works great! Thanks wenzel... also checked FF, Opera, Safari, and Chrome which continue to work happily.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.