668238 - [stage] IE9 - cannot share marks via twitter or facebook

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect)

Description

[Matt Brandt [:mbrandt]]

It appears that I'm unable to share marks via Facebook and Twitter in IE9. It appears to work fine in FF and Chrome
Steps to reproduce:
1. https://markup.allizom.org/en-US/#/linear/yNvD
2. click the Facebook or Twitter icon to share a mark

Expected:
A dialogue prompting the user through the process of sharing the mark appears.

Actual:
No Facebook or twitter prompt appears in the browser.

This is what I'm seeing in IE9's developer console:
SCRIPT87: Invalid argument
markUp_app.min.js, line 8 character 19

Comment 1

[Fred Wenzel [:wenzel]]

I fixed this in:

https://github.com/mozilla/markup/commit/9dedb78

The internal window name contained spaces, which it "should" not. No browser but IE cares. I replaced it with a single word, and in my tests it works. Hasn't shown up on markup-dev yet unfortunately.

Comment 2

[Matt Brandt [:mbrandt]]

Verified... IE9 works great! Thanks wenzel... also checked FF, Opera, Safari, and Chrome which continue to work happily.