Closed
Bug 668305
Opened 13 years ago
Closed 12 years ago
IonMonkey: Implement more efficient BitSet iteration
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: adrake, Assigned: jandem)
References
Details
Attachments
(1 file)
9.09 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Tracking bug for the associated FIXME in the code. BitSet iteration currently uses a nasty linear time in maximum algorithm, it could use existing bit scan functionality and get better performance. This is far from the slowest thing in the code at the time, however.
Reporter | ||
Updated•13 years ago
|
Severity: normal → minor
Reporter | ||
Updated•13 years ago
|
Assignee: adrake → general
Assignee | ||
Comment 1•12 years ago
|
||
With JSOP_TYPEOFEXPR (bug 732927), Kraken audio-beat-detection spends about 170 ms (> 30%) in LSRA. The attached patch optimizes BitSet::Iterator and inlines some common BitSet methods. audio-detection regalloc time drops from 170 ms to 76 ms.
Updated•12 years ago
|
Attachment #602874 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/projects/ionmonkey/rev/353d96c69c6b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•