Closed Bug 668305 Opened 9 years ago Closed 8 years ago

IonMonkey: Implement more efficient BitSet iteration

Categories

(Core :: JavaScript Engine, defect, minor)

x86_64
Linux
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: adrake, Assigned: jandem)

References

Details

Attachments

(1 file)

Tracking bug for the associated FIXME in the code. BitSet iteration currently uses a nasty linear time in maximum algorithm, it could use existing bit scan functionality and get better performance. This is far from the slowest thing in the code at the time, however.
Assignee: general → adrake
Blocks: 657816
Severity: normal → minor
Assignee: adrake → general
Attached patch PatchSplinter Review
With JSOP_TYPEOFEXPR (bug 732927), Kraken audio-beat-detection spends about 170 ms (> 30%) in LSRA.

The attached patch optimizes BitSet::Iterator and inlines some common BitSet methods. audio-detection regalloc time drops from 170 ms to 76 ms.
Assignee: general → jdemooij
Status: NEW → ASSIGNED
Attachment #602874 - Flags: review?(dvander)
Attachment #602874 - Flags: review?(dvander) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/353d96c69c6b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.