Closed Bug 668328 Opened 12 years ago Closed 12 years ago

nsEventListenerManager doesn't initialize new bitfield members

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla7

People

(Reporter: jdm, Unassigned)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file, 1 obsolete file)

Initialize members of nsEventListenerManager on construction.
1.19 KB, patch
sicking
: review+
Details | Diff | Splinter Review 
      No description provided.
Summary: nsEventListenerManager::mMayHaveCapturingListeners potentially uninitialized → nsEventListenerManager doesn't initialize new bitfield members

        Attachment #542918 -
        Flags: review?(jonas)

    
  

        Attachment #542918 -
        Attachment is obsolete: true

        Attachment #542918 -
        Flags: review?(jonas)

    
    

    
  
Comment on attachment 542930 [details] [diff] [review]
Initialize members of nsEventListenerManager on construction.

Review of attachment 542930 [details] [diff] [review]:
-----------------------------------------------------------------

Hah! That's pretty bad that that wasn't there before.

        Attachment #542930 -
        Flags: review?(jonas) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/cdc314af3241
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7

    
    

    
  
As visible when opening the link in the above comment, the initialization is now done:
    1.12 +  mMayHavePaintEventListener(PR_FALSE),
    1.13 +  mMayHaveMutationListeners(PR_FALSE),
    1.14 +  mMayHaveCapturingListeners(PR_FALSE),
    1.15 +  mMayHaveSystemGroupListeners(PR_FALSE),
    1.16 +  mMayHaveAudioAvailableEventListener(PR_FALSE),
    1.17 +  mMayHaveTouchEventListener(PR_FALSE),
    1.18 +  mNoListenerForEvent(0)
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.