Last Comment Bug 668328 - nsEventListenerManager doesn't initialize new bitfield members
: nsEventListenerManager doesn't initialize new bitfield members
Status: VERIFIED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla7
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks: 658714
  Show dependency treegraph
 
Reported: 2011-06-29 13:09 PDT by Josh Matthews [:jdm]
Modified: 2011-09-12 07:08 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Initialize members of nsEventListenerManager on construction. (1.15 KB, patch)
2011-06-29 13:15 PDT, Josh Matthews [:jdm]
no flags Details | Diff | Review
Initialize members of nsEventListenerManager on construction. (1.19 KB, patch)
2011-06-29 13:54 PDT, Josh Matthews [:jdm]
jonas: review+
Details | Diff | Review

Description Josh Matthews [:jdm] 2011-06-29 13:09:54 PDT

    
Comment 1 Josh Matthews [:jdm] 2011-06-29 13:15:14 PDT
Created attachment 542918 [details] [diff] [review]
Initialize members of nsEventListenerManager on construction.
Comment 2 Josh Matthews [:jdm] 2011-06-29 13:54:10 PDT
Created attachment 542930 [details] [diff] [review]
Initialize members of nsEventListenerManager on construction.
Comment 3 Jonas Sicking (:sicking) PTO Until July 5th 2011-06-30 12:05:37 PDT
Comment on attachment 542930 [details] [diff] [review]
Initialize members of nsEventListenerManager on construction.

Review of attachment 542930 [details] [diff] [review]:
-----------------------------------------------------------------

Hah! That's pretty bad that that wasn't there before.
Comment 5 Marco Bonardo [::mak] 2011-07-02 01:53:11 PDT
http://hg.mozilla.org/mozilla-central/rev/cdc314af3241
Comment 6 Ioana (away) 2011-09-12 07:08:08 PDT
As visible when opening the link in the above comment, the initialization is now done:
    1.12 +  mMayHavePaintEventListener(PR_FALSE),
    1.13 +  mMayHaveMutationListeners(PR_FALSE),
    1.14 +  mMayHaveCapturingListeners(PR_FALSE),
    1.15 +  mMayHaveSystemGroupListeners(PR_FALSE),
    1.16 +  mMayHaveAudioAvailableEventListener(PR_FALSE),
    1.17 +  mMayHaveTouchEventListener(PR_FALSE),
    1.18 +  mNoListenerForEvent(0)

Note You need to log in before you can comment on or make changes to this bug.