nsEventListenerManager doesn't initialize new bitfield members

VERIFIED FIXED in mozilla7

Status

()

Core
DOM: Core & HTML
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: jdm, Unassigned)

Tracking

unspecified
mozilla7
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Reporter)

Updated

6 years ago
Summary: nsEventListenerManager::mMayHaveCapturingListeners potentially uninitialized → nsEventListenerManager doesn't initialize new bitfield members
(Reporter)

Comment 1

6 years ago
Created attachment 542918 [details] [diff] [review]
Initialize members of nsEventListenerManager on construction.
Attachment #542918 - Flags: review?(jonas)
(Reporter)

Comment 2

6 years ago
Created attachment 542930 [details] [diff] [review]
Initialize members of nsEventListenerManager on construction.
Attachment #542930 - Flags: review?(jonas)
(Reporter)

Updated

6 years ago
Attachment #542918 - Attachment is obsolete: true
Attachment #542918 - Flags: review?(jonas)
Comment on attachment 542930 [details] [diff] [review]
Initialize members of nsEventListenerManager on construction.

Review of attachment 542930 [details] [diff] [review]:
-----------------------------------------------------------------

Hah! That's pretty bad that that wasn't there before.
Attachment #542930 - Flags: review?(jonas) → review+
(Reporter)

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/cdc314af3241
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/cdc314af3241
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7

Comment 6

6 years ago
As visible when opening the link in the above comment, the initialization is now done:
    1.12 +  mMayHavePaintEventListener(PR_FALSE),
    1.13 +  mMayHaveMutationListeners(PR_FALSE),
    1.14 +  mMayHaveCapturingListeners(PR_FALSE),
    1.15 +  mMayHaveSystemGroupListeners(PR_FALSE),
    1.16 +  mMayHaveAudioAvailableEventListener(PR_FALSE),
    1.17 +  mMayHaveTouchEventListener(PR_FALSE),
    1.18 +  mNoListenerForEvent(0)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.