Closed Bug 668417 Opened 13 years ago Closed 13 years ago

Firefox restores only the app tabs in one of my windows

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Version:
9 Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED DUPLICATE of bug 669196
Milestone:
Firefox 8

People

(Reporter: ehsan.akhgari, Unassigned)

References

Details

(Keywords: dataloss, regression) 

I was bitten by this problem once before, but this time I have a copy of my sessionstore.js file.

STR:
1. Setup Firefox to restore your windows and tabs from the last time.
2. Copy my sessionstore file in your profile dir.
3. Start Firefox.

The second window is restored with only the app tabs (without any of my regular tabs).  The first window is restored fine (but I don't have any app tabs in it -- don't know if it's relevant or not).
Forgot to mention that I see this on trunk in safe mode.
Ehsan, can you use the mozregression tool to identify a regression window and changeset?
http://harthur.github.com/mozregression/

I'm unable to reproduce this issue locally.
(In reply to comment #3)
> Ehsan, can you use the mozregression tool to identify a regression window and
> changeset?
> http://harthur.github.com/mozregression/
> 
> I'm unable to reproduce this issue locally.

I tried to do that yesterday, but I couldn't get it to install.  Is there any way to install it and all of its dependencies in a single directory, and not mess with the packaging stuff?
Ehsan, any chance you could send me the session file to look at? Nothing is jumping to mind - it could be that something got into a weird state when saving the file and it's actually being restored like it sees it or it's restoring weird.
I have seen this on Nightly in recent days on both Mac and Windows. On the latter for example I have 6 windows, only 1 with app tabs. All windows restore correctly except for the app tabs window where all tabs are lost except the app tabs.
I took a look at Ehsan's sessionstore.js and the window in question just doesn't have any tabs besides the pinned ones (there are closed tabs). That would explain why it only opens that way. But obviously something is causing it to be saved that way.
I've just had it happen again in Nightly with the following use case:

- Close Nightly with an update pending to be applied
- Click on a web link in email (or another application)
- Watch as the update is being applied (dialog)

When Nightly starts, the web link from email is not open, and only app tabs remain in the window(s). I'm not sure if it is window or windows, as I only have app tabs in 1 window. My other non-app-tab windows remain intact.
How quickly after opening the web link did you restart Firefox? By default Session Store saves every 10 seconds. If you restarted less than 10 seconds after clicking the link it is possible it did not get saved as part of your session.
Paul thinks I just hit this bug too... I restarted from a somewhat old build (pre 7/17ish), and only got 3 app tabs restored.

Of particular interest might be that I actually had _4_ apptabs, the 4th being Google+. That one didn't get restored. And I had only pinned it a few days previously.
I think I just hit this as well, but no Google+ opened.
(In reply to comment #9)
> How quickly after opening the web link did you restart Firefox? By default
> Session Store saves every 10 seconds. If you restarted less than 10 seconds
> after clicking the link it is possible it did not get saved as part of your
> session.

Definitely less than 10 seconds ... very quick. I'm don't really understand what you are saying though.
(In reply to comment #10)
> Of particular interest might be that I actually had _4_ apptabs, the 4th
> being Google+. That one didn't get restored. And I had only pinned it a few
> days previously.

I get this too. As well as losing the other tabs, I lose 2 app tabs that I added in recent days.
I verified that opening a new tab will update the timestamp on sessionstore.js.
And on restart, Aurora hung, but after killing it, restarted with the correct session - so I'm not much help in reproducing :(
Seems that this was probably a dupe. If this happens again, please reopen.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
Target Milestone: --- → Firefox 8
Version: Trunk → 9 Branch
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.