668489 - Add method to retrieve add-ons src parameter of installation link

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Maniac Vlad Florin (:vladmaniac)]

This is the code we should wrap into a API method 

var addonUrl = addToFirefox.getNode().href;
  var addonSRC = addonUrl.indexOf("src=discovery-promo");
  var checkSRC = (addonSRC !== -1);

  controller.assert(function () {
    return checkSRC;
  }, "Add-on URL has an SRC value - got '" + checkSRC +
     "', expected 'true'");

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We will have a method for the API which will return the value of the src parameter of the installation link. Checks have to be performed in the test.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Retrieves only the value of the src param which can then be used by tests to do direct comparison without knowing the details of the URL.

Geo, if that's ok please check the patch into all branches from default down to mozilla-release.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1.1

I should do a qrefresh first. Sorry.

Comment 4

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 543116 [details] [diff] [review]
Patch v1.1

Looks fine. 

Still encourage you to put comments above any regexes a la "src looks like 'src=######&'" or something so people know what you're trying to do, but I wouldn't block the patch on that. 

It's just really useful when it comes time to update the regex (or figure out why it's not doing what it's supposed to).

I'll land as requested.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Geo, I will land and update the patch with the proposal you made.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/a9bfeff7c9ed (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/a822fc5c54cd (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/da41041b3f47 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/05b7365fbf1d (release)

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v2

Updated patch with review comments.