Closed
Bug 668489
Opened 13 years ago
Closed 13 years ago
Add method to retrieve add-ons src parameter of installation link
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vladmaniac, Assigned: whimboo)
References
Details
(Whiteboard: [lib])
Attachments
(1 file, 2 obsolete files)
1.30 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
This is the code we should wrap into a API method var addonUrl = addToFirefox.getNode().href; var addonSRC = addonUrl.indexOf("src=discovery-promo"); var checkSRC = (addonSRC !== -1); controller.assert(function () { return checkSRC; }, "Add-on URL has an SRC value - got '" + checkSRC + "', expected 'true'");
Assignee | ||
Comment 1•13 years ago
|
||
We will have a method for the API which will return the value of the src parameter of the installation link. Checks have to be performed in the test.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86 → All
Summary: Add method to check Add-ons SRC attribute while installing addons → Add method to retrieve add-ons src parameter of installation link
Whiteboard: [shared module]
Assignee | ||
Comment 2•13 years ago
|
||
Retrieves only the value of the src param which can then be used by tests to do direct comparison without knowing the details of the URL. Geo, if that's ok please check the patch into all branches from default down to mozilla-release.
Attachment #543115 -
Flags: review?(gmealer)
Assignee | ||
Comment 3•13 years ago
|
||
I should do a qrefresh first. Sorry.
Attachment #543115 -
Attachment is obsolete: true
Attachment #543116 -
Flags: review?(gmealer)
Attachment #543115 -
Flags: review?(gmealer)
Comment on attachment 543116 [details] [diff] [review] Patch v1.1 Looks fine. Still encourage you to put comments above any regexes a la "src looks like 'src=######&'" or something so people know what you're trying to do, but I wouldn't block the patch on that. It's just really useful when it comes time to update the regex (or figure out why it's not doing what it's supposed to). I'll land as requested.
Attachment #543116 -
Flags: review?(gmealer) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Geo, I will land and update the patch with the proposal you made.
Assignee | ||
Comment 6•13 years ago
|
||
Landed as: http://hg.mozilla.org/qa/mozmill-tests/rev/a9bfeff7c9ed (default) http://hg.mozilla.org/qa/mozmill-tests/rev/a822fc5c54cd (aurora) http://hg.mozilla.org/qa/mozmill-tests/rev/da41041b3f47 (beta) http://hg.mozilla.org/qa/mozmill-tests/rev/05b7365fbf1d (release)
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•13 years ago
|
||
Updated patch with review comments.
Attachment #543116 -
Attachment is obsolete: true
Attachment #543297 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Component: Mozmill Tests → Mozmill Shared Modules
Assignee | ||
Updated•12 years ago
|
Component: Mozmill Shared Modules → Mozmill Tests
Assignee | ||
Updated•12 years ago
|
Whiteboard: [shared module] → [lib]
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•